diff options
author | Glenn Kasten <gkasten@google.com> | 2012-02-24 15:42:48 -0800 |
---|---|---|
committer | Glenn Kasten <gkasten@google.com> | 2012-02-29 07:01:44 -0800 |
commit | f2218b7549d4aeedc4c99c6c43afc4ccc644a40a (patch) | |
tree | 50d3977c8693cf624f9e89e9b63e878bf5f94280 /services/audioflinger | |
parent | f64dfccd96286255fd382486c94cdb48921c45fa (diff) | |
download | frameworks_base-f2218b7549d4aeedc4c99c6c43afc4ccc644a40a.zip frameworks_base-f2218b7549d4aeedc4c99c6c43afc4ccc644a40a.tar.gz frameworks_base-f2218b7549d4aeedc4c99c6c43afc4ccc644a40a.tar.bz2 |
Update AudioFlinger comments
Add comments to enum mixer_state
Note side-effect of lockEffectChains_l
Fix a typo
Change-Id: Ibd51678bac2193201cbcbe081ff5664046fbc494
Diffstat (limited to 'services/audioflinger')
-rw-r--r-- | services/audioflinger/AudioFlinger.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/services/audioflinger/AudioFlinger.h b/services/audioflinger/AudioFlinger.h index e908d3f..8128b93 100644 --- a/services/audioflinger/AudioFlinger.h +++ b/services/audioflinger/AudioFlinger.h @@ -455,9 +455,10 @@ private: virtual status_t addEffectChain_l(const sp<EffectChain>& chain) = 0; // remove an effect chain from the chain list (mEffectChains) virtual size_t removeEffectChain_l(const sp<EffectChain>& chain) = 0; - // lock mall effect chains Mutexes. Must be called before releasing the + // lock all effect chains Mutexes. Must be called before releasing the // ThreadBase mutex before processing the mixer and effects. This guarantees the // integrity of the chains during the process. + // Also sets the parameter 'effectChains' to current value of mEffectChains. void lockEffectChains_l(Vector<sp <EffectChain> >& effectChains); // unlock effect chains after process void unlockEffectChains(const Vector<sp<EffectChain> >& effectChains); @@ -575,9 +576,11 @@ private: public: enum mixer_state { - MIXER_IDLE, - MIXER_TRACKS_ENABLED, - MIXER_TRACKS_READY + MIXER_IDLE, // no active tracks + MIXER_TRACKS_ENABLED, // at least one active track, but no track has any data ready + MIXER_TRACKS_READY // at least one active track, and at least one track has data + // standby mode does not have an enum value + // suspend by audio policy manager is orthogonal to mixer state }; // playback track |