summaryrefslogtreecommitdiffstats
path: root/services/core/java/com/android/server/content
diff options
context:
space:
mode:
authorMatthew Williams <mjwilliams@google.com>2015-10-16 12:01:31 -0700
committerMatthew Williams <mjwilliams@google.com>2015-10-20 18:55:30 +0000
commit7d7a2254bc41d2dfc34fbb8693cb0dad2ccd528a (patch)
treeddba8db034a618312524d6cf1252d766990d96c8 /services/core/java/com/android/server/content
parentcfea184d6c0268b92ed55276d2b686962c8ee531 (diff)
downloadframeworks_base-7d7a2254bc41d2dfc34fbb8693cb0dad2ccd528a.zip
frameworks_base-7d7a2254bc41d2dfc34fbb8693cb0dad2ccd528a.tar.gz
frameworks_base-7d7a2254bc41d2dfc34fbb8693cb0dad2ccd528a.tar.bz2
DO NOT MERGE Sync extras bundle comparison can throw NPE
BUG: 23591205 Change-Id: Ic6404c0befe70c34b078e0eae6a627826173d82c (cherry picked from commit 9ad2c8403354a985258c098681067e74b9e2f638)
Diffstat (limited to 'services/core/java/com/android/server/content')
-rw-r--r--services/core/java/com/android/server/content/SyncManager.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/services/core/java/com/android/server/content/SyncManager.java b/services/core/java/com/android/server/content/SyncManager.java
index 334bc18..b61f90e 100644
--- a/services/core/java/com/android/server/content/SyncManager.java
+++ b/services/core/java/com/android/server/content/SyncManager.java
@@ -104,6 +104,7 @@ import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
import java.util.Random;
import java.util.Set;
@@ -3370,7 +3371,7 @@ public class SyncManager {
if (!smaller.containsKey(key)) {
return false;
}
- if (!bigger.get(key).equals(smaller.get(key))) {
+ if (!Objects.equals(bigger.get(key), smaller.get(key))) {
return false;
}
}
@@ -3378,7 +3379,6 @@ public class SyncManager {
}
/**
- * TODO: Get rid of this when we separate sync settings extras from dev specified extras.
* @return true if the provided key is used by the SyncManager in scheduling the sync.
*/
private static boolean isSyncSetting(String key) {