Always derive native library paths at runtime.

Over time, we've unpacked native libraries at various places with
respect to their source APK.  Persisting this path in PackageSettings
has caused more pain recently with the switch to supporting multiArch
and cluster installs.

This change switches us to always derive the native library paths at
runtime based on the type of install.  This also ensures that
transitioning between a bundled system app and an upgraded system
app will always build the right path.

We still persist the last generated path into PackageSettings to make
cleanup at uninstall time easier.

Bug: 16208505, 16206748, 16212206
Change-Id: Ieb82a424ca4a92b5674983453c50ba4b695abfb0

1 files changed, 4 insertions, 3 deletions

diff --git a/services/core/java/com/android/server/pm/PackageSettingBase.java b/services/core/java/com/android/server/pm/PackageSettingBase.java
index 3390efe..e164f5f 100644
--- a/services/core/java/com/android/server/pm/PackageSettingBase.java
+++ b/services/core/java/com/android/server/pm/PackageSettingBase.java
@@ -57,10 +57,11 @@ class PackageSettingBase extends GrantedPermissions {
     String resourcePathString;
 
     /**
-     * The path under which native libraries for legacy apps are unpacked.
-     * Will be set to {@code null} for newer installs, where the path can be
-     * derived from {@link #codePath} unambiguously.
+     * The path under which native libraries have been unpacked. This path is
+     * always derived at runtime, and is only stored here for cleanup when a
+     * package is uninstalled.
      */
+    @Deprecated
     String legacyNativeLibraryPathString;
 
     String primaryCpuAbiString;