summaryrefslogtreecommitdiffstats
path: root/services/core/java/com
diff options
context:
space:
mode:
authorYohei Yukawa <yukawa@google.com>2014-05-19 16:03:24 +0900
committerYohei Yukawa <yukawa@google.com>2014-05-19 16:18:36 +0900
commit9d91b43c8d0fa233905ecf132c6e6ee664904694 (patch)
treecc5bc610c6f2cee2bae94eabdfdcb6ecebb9e4cf /services/core/java/com
parentb0650e8ff3113f9b9dbb6d249339dbd7921b4517 (diff)
downloadframeworks_base-9d91b43c8d0fa233905ecf132c6e6ee664904694.zip
frameworks_base-9d91b43c8d0fa233905ecf132c6e6ee664904694.tar.gz
frameworks_base-9d91b43c8d0fa233905ecf132c6e6ee664904694.tar.bz2
Do not pass null to IInputMethod#setSessionEnabled
It doen't make sense to pass null as IInputMethodSession for IInputMethod#setSessionEnabled. If we do this, it causes NPE. BUG: 14980068 Change-Id: Ide48d098d5e7640890257e31f8872e79b9821eb2
Diffstat (limited to 'services/core/java/com')
-rw-r--r--services/core/java/com/android/server/InputMethodManagerService.java16
1 files changed, 8 insertions, 8 deletions
diff --git a/services/core/java/com/android/server/InputMethodManagerService.java b/services/core/java/com/android/server/InputMethodManagerService.java
index 0b9570d..50553ee 100644
--- a/services/core/java/com/android/server/InputMethodManagerService.java
+++ b/services/core/java/com/android/server/InputMethodManagerService.java
@@ -2369,20 +2369,20 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
void setEnabledSessionInMainThread(SessionState session) {
if (mEnabledSession != session) {
- if (mEnabledSession != null) {
+ if (mEnabledSession != null && mEnabledSession.session != null) {
try {
if (DEBUG) Slog.v(TAG, "Disabling: " + mEnabledSession);
- mEnabledSession.method.setSessionEnabled(
- mEnabledSession.session, false);
+ mEnabledSession.method.setSessionEnabled(mEnabledSession.session, false);
} catch (RemoteException e) {
}
}
mEnabledSession = session;
- try {
- if (DEBUG) Slog.v(TAG, "Enabling: " + mEnabledSession);
- session.method.setSessionEnabled(
- session.session, true);
- } catch (RemoteException e) {
+ if (mEnabledSession != null && mEnabledSession.session != null) {
+ try {
+ if (DEBUG) Slog.v(TAG, "Enabling: " + mEnabledSession);
+ mEnabledSession.method.setSessionEnabled(mEnabledSession.session, true);
+ } catch (RemoteException e) {
+ }
}
}
}