diff options
author | Robert Greenwalt <rgreenwalt@google.com> | 2013-02-22 14:57:00 -0800 |
---|---|---|
committer | Robert Greenwalt <rgreenwalt@google.com> | 2013-02-22 15:36:33 -0800 |
commit | e436e4f8a48a6bc3094c036166cca3911a540321 (patch) | |
tree | 9286b3b1844afbd675919b463622eba0e9fa7ea7 /services | |
parent | ea53d7e0a46f333642f3663ce54ee0d36b87b813 (diff) | |
download | frameworks_base-e436e4f8a48a6bc3094c036166cca3911a540321.zip frameworks_base-e436e4f8a48a6bc3094c036166cca3911a540321.tar.gz frameworks_base-e436e4f8a48a6bc3094c036166cca3911a540321.tar.bz2 |
Remove two new permission checks
These checks while technically reasonable are a hard to swallow API change
that may break existing apps and pragmatically serves no purpose: the protected
data is available in publicly readable java VM properties.
Change-Id: I522c493c2604a33e28d99e2be31054326c9a8323
Diffstat (limited to 'services')
-rw-r--r-- | services/java/com/android/server/ConnectivityService.java | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/services/java/com/android/server/ConnectivityService.java b/services/java/com/android/server/ConnectivityService.java index 7abd530..5e4855b 100644 --- a/services/java/com/android/server/ConnectivityService.java +++ b/services/java/com/android/server/ConnectivityService.java @@ -2999,7 +2999,10 @@ public class ConnectivityService extends IConnectivityManager.Stub { } public ProxyProperties getProxy() { - enforceAccessPermission(); + // this information is already available as a world read/writable jvm property + // so this API change wouldn't have a benifit. It also breaks the passing + // of proxy info to all the JVMs. + // enforceAccessPermission(); synchronized (mDefaultProxyLock) { return mDefaultProxyDisabled ? null : mDefaultProxy; } @@ -3051,7 +3054,10 @@ public class ConnectivityService extends IConnectivityManager.Stub { } public ProxyProperties getGlobalProxy() { - enforceAccessPermission(); + // this information is already available as a world read/writable jvm property + // so this API change wouldn't have a benifit. It also breaks the passing + // of proxy info to all the JVMs. + // enforceAccessPermission(); synchronized (mGlobalProxyLock) { return mGlobalProxy; } |