diff options
author | Daniel Sandler <dsandler@android.com> | 2013-05-22 14:24:20 -0400 |
---|---|---|
committer | Daniel Sandler <dsandler@android.com> | 2013-05-22 15:04:00 -0400 |
commit | ffcc976928f5709b4689b479e3885b3fdaf8b8b6 (patch) | |
tree | b258ba943e83db2d39c7e0ab6ea840f09c5a7466 /services | |
parent | c037282c1ca0d7589168c73f1cf8b19ecc3ffca4 (diff) | |
download | frameworks_base-ffcc976928f5709b4689b479e3885b3fdaf8b8b6.zip frameworks_base-ffcc976928f5709b4689b479e3885b3fdaf8b8b6.tar.gz frameworks_base-ffcc976928f5709b4689b479e3885b3fdaf8b8b6.tar.bz2 |
Temporarily restore some support for icon==0 notifications.
This is WRONG WRONG WRONG but certain apps rely on it to
poke the LED and so forth. In a future release this will
stop working.
Bug: 8623399
Change-Id: I49bb8ccc6891b1398ceec94c64d6c3a510ad1c38
Diffstat (limited to 'services')
-rw-r--r-- | services/java/com/android/server/NotificationManagerService.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/services/java/com/android/server/NotificationManagerService.java b/services/java/com/android/server/NotificationManagerService.java index f9b6eba..6a1ef45 100644 --- a/services/java/com/android/server/NotificationManagerService.java +++ b/services/java/com/android/server/NotificationManagerService.java @@ -1682,7 +1682,7 @@ public class NotificationManagerService extends INotificationManager.Stub notifyPostedLocked(r); } else { - Slog.e(TAG, "Ignoring notification with icon==0: " + notification); + Slog.e(TAG, "Not posting notification with icon==0: " + notification); if (old != null && old.statusBarKey != null) { long identity = Binder.clearCallingIdentity(); try { @@ -1694,7 +1694,9 @@ public class NotificationManagerService extends INotificationManager.Stub notifyRemovedLocked(r); } - return; // do not play sounds, show lights, etc. for invalid notifications + // ATTENTION: in a future release we will bail out here + // so that we do not play sounds, show lights, etc. for invalid notifications + Slog.e(TAG, "WARNING: In a future release this will crash the app: " + n.getPackageName()); } // If we're not supposed to beep, vibrate, etc. then don't. |