diff options
author | Jake Hamby <jhamby@google.com> | 2011-10-28 02:14:08 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2011-10-28 02:14:08 +0000 |
commit | e3a31d0340802352d568c8c35ff1fa1047018a42 (patch) | |
tree | b91a7b5a3fe78423fac0ed04224bc718523d41c6 /telephony/java | |
parent | a196c688ed1c8aa92d711b53c4dabd7d1399e740 (diff) | |
parent | 31d157bad27e4ecbe415f6f581946b6da7cc2ba3 (diff) | |
download | frameworks_base-e3a31d0340802352d568c8c35ff1fa1047018a42.zip frameworks_base-e3a31d0340802352d568c8c35ff1fa1047018a42.tar.gz frameworks_base-e3a31d0340802352d568c8c35ff1fa1047018a42.tar.bz2 |
am 31d157ba: Merge "Fix bug in enabling/disabling SMS cell broadcast activation." into ics-mr0
* commit '31d157bad27e4ecbe415f6f581946b6da7cc2ba3':
Fix bug in enabling/disabling SMS cell broadcast activation.
Diffstat (limited to 'telephony/java')
3 files changed, 16 insertions, 3 deletions
diff --git a/telephony/java/com/android/internal/telephony/IntRangeManager.java b/telephony/java/com/android/internal/telephony/IntRangeManager.java index 970bc44..cc7774d 100644 --- a/telephony/java/com/android/internal/telephony/IntRangeManager.java +++ b/telephony/java/com/android/internal/telephony/IntRangeManager.java @@ -543,6 +543,14 @@ public abstract class IntRangeManager { } /** + * Returns whether the list of ranges is completely empty. + * @return true if there are no enabled ranges + */ + public boolean isEmpty() { + return mRanges.isEmpty(); + } + + /** * Called when the list of enabled ranges has changed. This will be * followed by zero or more calls to {@link #addRange} followed by * a call to {@link #finishUpdate}. diff --git a/telephony/java/com/android/internal/telephony/RIL.java b/telephony/java/com/android/internal/telephony/RIL.java index e8d85de..9f93fb8 100644 --- a/telephony/java/com/android/internal/telephony/RIL.java +++ b/telephony/java/com/android/internal/telephony/RIL.java @@ -1956,7 +1956,7 @@ public final class RIL extends BaseCommands implements CommandsInterface { if (RILJ_LOGD) { riljLog(rr.serialString() + "> " + requestToString(rr.mRequest) - + " with " + numOfConfig + "configs : "); + + " with " + numOfConfig + " configs : "); for (int i = 0; i < numOfConfig; i++) { riljLog(config[i].toString()); } diff --git a/telephony/java/com/android/internal/telephony/gsm/SimSmsInterfaceManager.java b/telephony/java/com/android/internal/telephony/gsm/SimSmsInterfaceManager.java index 8d0e5d3..92bf390 100644 --- a/telephony/java/com/android/internal/telephony/gsm/SimSmsInterfaceManager.java +++ b/telephony/java/com/android/internal/telephony/gsm/SimSmsInterfaceManager.java @@ -246,6 +246,8 @@ public class SimSmsInterfaceManager extends IccSmsInterfaceManager { log("Added cell broadcast subscription for MID range " + startMessageId + " to " + endMessageId + " from client " + client); + setCellBroadcastActivation(!mCellBroadcastRangeManager.isEmpty()); + return true; } @@ -271,6 +273,8 @@ public class SimSmsInterfaceManager extends IccSmsInterfaceManager { log("Removed cell broadcast subscription for MID range " + startMessageId + " to " + endMessageId + " from client " + client); + setCellBroadcastActivation(!mCellBroadcastRangeManager.isEmpty()); + return true; } @@ -301,14 +305,15 @@ public class SimSmsInterfaceManager extends IccSmsInterfaceManager { /** * Called to indicate the end of a range update started by the * previous call to {@link #startUpdate}. + * @return true if successful, false otherwise */ protected boolean finishUpdate() { if (mConfigList.isEmpty()) { - return setCellBroadcastActivation(false); + return true; } else { SmsBroadcastConfigInfo[] configs = mConfigList.toArray(new SmsBroadcastConfigInfo[mConfigList.size()]); - return setCellBroadcastConfig(configs) && setCellBroadcastActivation(true); + return setCellBroadcastConfig(configs); } } } |