summaryrefslogtreecommitdiffstats
path: root/tests/DumpRenderTree/assets
diff options
context:
space:
mode:
authorSteve Block <steveblock@google.com>2010-02-25 12:50:33 +0000
committerSteve Block <steveblock@google.com>2010-02-26 17:19:51 +0000
commit12077e1179b4035ae2b1a44ccf9cd540e14b182e (patch)
tree29ce73bbc15c9c33c7c70db0f711da2e139858b1 /tests/DumpRenderTree/assets
parent2ec30697c6cc6812dfaeb9a2e7d1da0443aeb8e6 (diff)
downloadframeworks_base-12077e1179b4035ae2b1a44ccf9cd540e14b182e.zip
frameworks_base-12077e1179b4035ae2b1a44ccf9cd540e14b182e.tar.gz
frameworks_base-12077e1179b4035ae2b1a44ccf9cd540e14b182e.tar.bz2
Adds to DumpRenderTree the ability to look for Android-specific results
These Android-specific results will be added to external/webkit/LayoutTests/platform/android-<js-engine> and are used in preference to the generic expected results. The JavaScript engine to use is read from the JS_ENGINE environment variable used by the build system or can be overridden on the command line. If neither is set, it defaults to JSC. Change-Id: Ia8d107ced3968a5c061fd6f0f57451419bab6b27
Diffstat (limited to 'tests/DumpRenderTree/assets')
-rwxr-xr-xtests/DumpRenderTree/assets/run_layout_tests.py14
1 files changed, 14 insertions, 0 deletions
diff --git a/tests/DumpRenderTree/assets/run_layout_tests.py b/tests/DumpRenderTree/assets/run_layout_tests.py
index c3627bb..7f3ef2d 100755
--- a/tests/DumpRenderTree/assets/run_layout_tests.py
+++ b/tests/DumpRenderTree/assets/run_layout_tests.py
@@ -26,6 +26,7 @@
--time-out-ms (default is 8000 millis) for each test
--adb-options="-e" passes option string to adb
--results-directory=..., (default is ./layout-test-results) directory name under which results are stored.
+ --js-engine the JavaScript engine currently in use, determines which set of Android-specific expected results we should use, should be 'jsc' or 'v8'
"""
import logging
@@ -186,6 +187,16 @@ def main(options, args):
run_layout_test_cmd_postfix = " -e path \"" + path + "\" -e timeout " + timeout_ms
if options.rebaseline:
run_layout_test_cmd_postfix += " -e rebaseline true"
+
+ # If the JS engine is not specified on the command line, try reading the
+ # JS_ENGINE environment variable, which is used by the build system in
+ # external/webkit/Android.mk.
+ js_engine = options.js_engine
+ if not js_engine:
+ js_engine = os.environ['JS_ENGINE']
+ if js_engine:
+ run_layout_test_cmd_postfix += " -e jsengine " + js_engine
+
run_layout_test_cmd_postfix += " -w com.android.dumprendertree/.LayoutTestsAutoRunner"
# Call LayoutTestsAutoTest::startLayoutTests.
@@ -297,6 +308,9 @@ if '__main__' == __name__:
default=None,
dest="ref_directory",
help="directory where reference results are stored.")
+ option_parser.add_option("", "--js-engine",
+ default=None,
+ help="The JavaScript engine currently in use, which determines which set of Android-specific expected results we should use. Should be 'jsc' or 'v8'.");
options, args = option_parser.parse_args();
main(options, args)