diff options
author | Erik Pasternak <roboerik@android.com> | 2014-07-10 22:51:34 +0000 |
---|---|---|
committer | Erik Pasternak <roboerik@android.com> | 2014-07-10 22:51:34 +0000 |
commit | b2e93efcac593f5f27722219b274bd0fa5c1b0fe (patch) | |
tree | b36611df2d01aedf0f00c43bb6badf1dffb59c06 /tests/OneMedia | |
parent | 5a4e01114361b7dad4fc5465b4da00fd444fc098 (diff) | |
download | frameworks_base-b2e93efcac593f5f27722219b274bd0fa5c1b0fe.zip frameworks_base-b2e93efcac593f5f27722219b274bd0fa5c1b0fe.tar.gz frameworks_base-b2e93efcac593f5f27722219b274bd0fa5c1b0fe.tar.bz2 |
Revert "Make PlaybackState immutable with a builder"
Will resubmit tomorrow for Build Breakage Friday as this change needs new SDK prebuilts for unbundled app branches.
This reverts commit aa746b27610680a2c0fbdf7d81a6455c4597f05e.
Change-Id: I28ba7e1b09234a5eb1b725aed043b9de98e1bc16
Diffstat (limited to 'tests/OneMedia')
-rw-r--r-- | tests/OneMedia/src/com/android/onemedia/PlayerSession.java | 48 | ||||
-rw-r--r-- | tests/OneMedia/src/com/android/onemedia/provider/OneMediaRouteProvider.java | 37 |
2 files changed, 32 insertions, 53 deletions
diff --git a/tests/OneMedia/src/com/android/onemedia/PlayerSession.java b/tests/OneMedia/src/com/android/onemedia/PlayerSession.java index af24438..a220107 100644 --- a/tests/OneMedia/src/com/android/onemedia/PlayerSession.java +++ b/tests/OneMedia/src/com/android/onemedia/PlayerSession.java @@ -25,7 +25,6 @@ import android.media.session.MediaSession; import android.media.session.MediaSessionManager; import android.media.session.PlaybackState; import android.os.Bundle; -import android.os.SystemClock; import android.util.Log; import android.view.KeyEvent; @@ -59,9 +58,9 @@ public class PlayerSession { mRenderer = new LocalRenderer(context, null); mCallback = new SessionCb(); mRenderListener = new RenderListener(); - PlaybackState.Builder psBob = new PlaybackState.Builder(); - psBob.setActions(PlaybackState.ACTION_PAUSE | PlaybackState.ACTION_PLAY); - mPlaybackState = psBob.build(); + mPlaybackState = new PlaybackState(); + mPlaybackState.setActions(PlaybackState.ACTION_PAUSE + | PlaybackState.ACTION_PLAY); mRenderer.registerListener(mRenderListener); @@ -119,10 +118,7 @@ public class PlayerSession { private void updateState(int newState) { float rate = newState == PlaybackState.STATE_PLAYING ? 1 : 0; long position = mRenderer == null ? -1 : mRenderer.getSeekPosition(); - PlaybackState.Builder bob = new PlaybackState.Builder(mPlaybackState); - bob.setState(newState, position, rate, SystemClock.elapsedRealtime()); - bob.setErrorMessage(null); - mPlaybackState = bob.build(); + mPlaybackState.setState(newState, position, rate); mSession.setPlaybackState(mPlaybackState); } @@ -135,12 +131,10 @@ public class PlayerSession { @Override public void onError(int type, int extra, Bundle extras, Throwable error) { Log.d(TAG, "Sending onError with type " + type + " and extra " + extra); - PlaybackState.Builder bob = new PlaybackState.Builder(mPlaybackState); - bob.setState(PlaybackState.STATE_ERROR, -1, 0, 0); + mPlaybackState.setState(PlaybackState.STATE_ERROR, -1, 0); if (error != null) { - bob.setErrorMessage(error.getLocalizedMessage()); + mPlaybackState.setErrorMessage(error.getLocalizedMessage()); } - mPlaybackState = bob.build(); mSession.setPlaybackState(mPlaybackState); if (mListener != null) { mListener.onPlayStateChanged(mPlaybackState); @@ -149,41 +143,36 @@ public class PlayerSession { @Override public void onStateChanged(int newState) { + if (newState != Renderer.STATE_ERROR) { + mPlaybackState.setErrorMessage(null); + } long position = -1; if (mRenderer != null) { position = mRenderer.getSeekPosition(); } - int pbState; - float rate = 0; - String errorMsg = null; switch (newState) { case Renderer.STATE_ENDED: case Renderer.STATE_STOPPED: - pbState = PlaybackState.STATE_STOPPED; + mPlaybackState.setState(PlaybackState.STATE_STOPPED, position, 0); break; case Renderer.STATE_INIT: case Renderer.STATE_PREPARING: - pbState = PlaybackState.STATE_BUFFERING; + mPlaybackState.setState(PlaybackState.STATE_BUFFERING, position, 0); break; case Renderer.STATE_ERROR: - pbState = PlaybackState.STATE_ERROR; + mPlaybackState.setState(PlaybackState.STATE_ERROR, position, 0); break; case Renderer.STATE_PAUSED: - pbState = PlaybackState.STATE_PAUSED; + mPlaybackState.setState(PlaybackState.STATE_PAUSED, position, 0); break; case Renderer.STATE_PLAYING: - pbState = PlaybackState.STATE_PLAYING; - rate = 1; + mPlaybackState.setState(PlaybackState.STATE_PLAYING, position, 1); break; default: - pbState = PlaybackState.STATE_ERROR; - errorMsg = "unknown state"; + mPlaybackState.setState(PlaybackState.STATE_ERROR, position, 0); + mPlaybackState.setErrorMessage("unkown state"); break; } - PlaybackState.Builder bob = new PlaybackState.Builder(mPlaybackState); - bob.setState(pbState, position, rate, SystemClock.elapsedRealtime()); - bob.setErrorMessage(errorMsg); - mPlaybackState = bob.build(); mSession.setPlaybackState(mPlaybackState); if (mListener != null) { mListener.onPlayStateChanged(mPlaybackState); @@ -198,10 +187,7 @@ public class PlayerSession { public void onFocusLost() { Log.d(TAG, "Focus lost, changing state to " + Renderer.STATE_PAUSED); long position = mRenderer == null ? -1 : mRenderer.getSeekPosition(); - PlaybackState.Builder bob = new PlaybackState.Builder(mPlaybackState); - bob.setState(PlaybackState.STATE_PAUSED, position, 0, SystemClock.elapsedRealtime()); - bob.setErrorMessage(null); - mPlaybackState = bob.build(); + mPlaybackState.setState(PlaybackState.STATE_PAUSED, position, 0); mSession.setPlaybackState(mPlaybackState); if (mListener != null) { mListener.onPlayStateChanged(mPlaybackState); diff --git a/tests/OneMedia/src/com/android/onemedia/provider/OneMediaRouteProvider.java b/tests/OneMedia/src/com/android/onemedia/provider/OneMediaRouteProvider.java index 0284a03..f2d691c 100644 --- a/tests/OneMedia/src/com/android/onemedia/provider/OneMediaRouteProvider.java +++ b/tests/OneMedia/src/com/android/onemedia/provider/OneMediaRouteProvider.java @@ -28,7 +28,6 @@ import android.os.Bundle; import android.os.Handler; import android.os.Looper; import android.os.ResultReceiver; -import android.os.SystemClock; import android.util.Log; import com.android.onemedia.playback.LocalRenderer; @@ -61,9 +60,9 @@ public class OneMediaRouteProvider extends RouteProviderService { mRouteId = UUID.randomUUID().toString(); mRenderer = new LocalRenderer(this, null); mRenderListener = new RenderListener(); - PlaybackState.Builder bob = new PlaybackState.Builder(); - bob.setActions(PlaybackState.ACTION_PAUSE | PlaybackState.ACTION_PLAY); - mPlaybackState = bob.build(); + mPlaybackState = new PlaybackState(); + mPlaybackState.setActions(PlaybackState.ACTION_PAUSE + | PlaybackState.ACTION_PLAY); mRenderer.registerListener(mRenderListener); @@ -156,41 +155,36 @@ public class OneMediaRouteProvider extends RouteProviderService { @Override public void onStateChanged(int newState) { + if (newState != Renderer.STATE_ERROR) { + mPlaybackState.setErrorMessage(null); + } long position = -1; if (mRenderer != null) { position = mRenderer.getSeekPosition(); } - int pbState; - float rate = 0; - String errorMsg = null; switch (newState) { case Renderer.STATE_ENDED: case Renderer.STATE_STOPPED: - pbState = PlaybackState.STATE_STOPPED; + mPlaybackState.setState(PlaybackState.STATE_STOPPED, position, 0); break; case Renderer.STATE_INIT: case Renderer.STATE_PREPARING: - pbState = PlaybackState.STATE_BUFFERING; + mPlaybackState.setState(PlaybackState.STATE_BUFFERING, position, 0); break; case Renderer.STATE_ERROR: - pbState = PlaybackState.STATE_ERROR; + mPlaybackState.setState(PlaybackState.STATE_ERROR, position, 0); break; case Renderer.STATE_PAUSED: - pbState = PlaybackState.STATE_PAUSED; + mPlaybackState.setState(PlaybackState.STATE_PAUSED, position, 0); break; case Renderer.STATE_PLAYING: - pbState = PlaybackState.STATE_PLAYING; - rate = 1; + mPlaybackState.setState(PlaybackState.STATE_PLAYING, position, 1); break; default: - pbState = PlaybackState.STATE_ERROR; - errorMsg = "unknown state"; + mPlaybackState.setState(PlaybackState.STATE_ERROR, position, 0); + mPlaybackState.setErrorMessage("unkown state"); break; } - PlaybackState.Builder bob = new PlaybackState.Builder(mPlaybackState); - bob.setState(pbState, position, rate, SystemClock.elapsedRealtime()); - bob.setErrorMessage(errorMsg); - mPlaybackState = bob.build(); mControls.sendPlaybackChangeEvent(mPlaybackState.getState()); } @@ -201,9 +195,8 @@ public class OneMediaRouteProvider extends RouteProviderService { @Override public void onFocusLost() { - Log.d(TAG, "Focus lost, pausing"); - // Don't update state here, we'll get a separate call to - // onStateChanged when it pauses + Log.d(TAG, "Focus lost, changing state to " + Renderer.STATE_PAUSED); + mPlaybackState.setState(PlaybackState.STATE_PAUSED, mRenderer.getSeekPosition(), 0); mRenderer.onPause(); } |