summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorBrad Fitzpatrick <bradfitz@android.com>2009-10-26 14:03:54 -0700
committerBrad Fitzpatrick <bradfitz@android.com>2009-10-26 14:46:25 -0700
commit70ece8d334485af47edfb5bf3049bef2cf5f4df6 (patch)
tree2a51ceb2d3fdc3e5670614454590208e8ecfb442 /tests
parent52c931b7dd0c5f82f409dea85a62c1e6c9e17c35 (diff)
downloadframeworks_base-70ece8d334485af47edfb5bf3049bef2cf5f4df6.zip
frameworks_base-70ece8d334485af47edfb5bf3049bef2cf5f4df6.tar.gz
frameworks_base-70ece8d334485af47edfb5bf3049bef2cf5f4df6.tar.bz2
Speed up Uri.getQueryParameter by allocating less.
Sample hierarchial URL, from my ContactsProvider test case: content://com.android.contacts/data?account_name=braddroid%40gmail.com&account_type=com.google.GAIA&caller_is_syncadapter=true Without this patch: (fetching the "account_name" parameter) 10000 iters: 0.5293 ms average 10000 iters: 0.5119 ms average 10000 iters: 0.5158 ms average With this patch, rewriting it to not allocate memory (no implicit StringBuilder), but still no caching: 1) when it needs to decode something (i.e account_name above; allocates memory) 50000 iters: 0.28724 ms average 50000 iters: 0.31774 ms average 50000 iters: 0.28764 ms average 2) when it doesn't need to decode (and thus allocate memory, i.e. account_type above) 50000 iters: 0.0954 ms average 50000 iters: 0.09124 ms average 50000 iters: 0.09088 ms average
Diffstat (limited to 'tests')
-rw-r--r--tests/AndroidTests/src/com/android/unit_tests/UriTest.java29
1 files changed, 29 insertions, 0 deletions
diff --git a/tests/AndroidTests/src/com/android/unit_tests/UriTest.java b/tests/AndroidTests/src/com/android/unit_tests/UriTest.java
index d17e2c3..42066d9 100644
--- a/tests/AndroidTests/src/com/android/unit_tests/UriTest.java
+++ b/tests/AndroidTests/src/com/android/unit_tests/UriTest.java
@@ -541,4 +541,33 @@ public class UriTest extends TestCase {
assertEquals(nestedUrl,
Uri.decode(uri.getQueryParameters("nested").get(0)));
}
+
+ public void testGetQueryParameterEdgeCases() {
+ Uri uri;
+
+ // key at beginning of URL
+ uri = Uri.parse("http://test/").buildUpon()
+ .appendQueryParameter("key", "a b")
+ .appendQueryParameter("keya", "c d")
+ .appendQueryParameter("bkey", "e f")
+ .build();
+ assertEquals("a b", uri.getQueryParameter("key"));
+
+ // key in middle of URL
+ uri = Uri.parse("http://test/").buildUpon()
+ .appendQueryParameter("akeyb", "a b")
+ .appendQueryParameter("keya", "c d")
+ .appendQueryParameter("key", "e f")
+ .appendQueryParameter("bkey", "g h")
+ .build();
+ assertEquals("e f", uri.getQueryParameter("key"));
+
+ // key at end of URL
+ uri = Uri.parse("http://test/").buildUpon()
+ .appendQueryParameter("akeyb", "a b")
+ .appendQueryParameter("keya", "c d")
+ .appendQueryParameter("key", "y z")
+ .build();
+ assertEquals("y z", uri.getQueryParameter("key"));
+ }
}