diff options
author | Chet Haase <chet@google.com> | 2013-06-06 16:34:33 -0700 |
---|---|---|
committer | Chet Haase <chet@google.com> | 2013-06-06 16:43:41 -0700 |
commit | f4130cf35fa128e36f96e55955d4f5db86197e4a (patch) | |
tree | 0ae8a2c211bebc906d67402e3aa7e0c5b801babe /tests | |
parent | ae8f82f2015612a659b95007c355d12c83fbcefc (diff) | |
download | frameworks_base-f4130cf35fa128e36f96e55955d4f5db86197e4a.zip frameworks_base-f4130cf35fa128e36f96e55955d4f5db86197e4a.tar.gz frameworks_base-f4130cf35fa128e36f96e55955d4f5db86197e4a.tar.bz2 |
Additional functionality and performance for ArrayMap
Added equals() and hashCode() to ArrayMap to allow equals() tests
of maps with the same key/value pairs to return true.
Changed putAll() to handle the case of an empty map faster, just copying
the arrays instead of adding elements one by one.
Added to ArrayMapTests to test new equals() and copy constructor
functionality.
Issue #9299310 Optimize ArrayMap copy constructor
Change-Id: I1186a0eddd1fd53a0f380c2f3972fc1942cdf879
Diffstat (limited to 'tests')
-rw-r--r-- | tests/ActivityTests/src/com/google/android/test/activity/ArrayMapTests.java | 68 |
1 files changed, 68 insertions, 0 deletions
diff --git a/tests/ActivityTests/src/com/google/android/test/activity/ArrayMapTests.java b/tests/ActivityTests/src/com/google/android/test/activity/ArrayMapTests.java index d9e1a83..7d82cd3 100644 --- a/tests/ActivityTests/src/com/google/android/test/activity/ArrayMapTests.java +++ b/tests/ActivityTests/src/com/google/android/test/activity/ArrayMapTests.java @@ -247,6 +247,18 @@ public class ArrayMapTests { } } + private static void dump(ArrayMap map1, ArrayMap map2) { + Log.e("test", "ArrayMap of " + map1.size() + " entries:"); + Set<Map.Entry> mapSet = map1.entrySet(); + for (int i=0; i<map2.size(); i++) { + Log.e("test", " " + map1.keyAt(i) + " -> " + map1.valueAt(i)); + } + Log.e("test", "ArrayMap of " + map2.size() + " entries:"); + for (int i=0; i<map2.size(); i++) { + Log.e("test", " " + map2.keyAt(i) + " -> " + map2.valueAt(i)); + } + } + public static void run() { HashMap<ControlledHash, Integer> mHashMap = new HashMap<ControlledHash, Integer>(); ArrayMap<ControlledHash, Integer> mArrayMap = new ArrayMap<ControlledHash, Integer>(); @@ -297,7 +309,63 @@ public class ArrayMapTests { dump(mHashMap, mArrayMap); } + if (!equalsTest()) { + return; + } + + // copy constructor test + ArrayMap newMap = new ArrayMap<Integer, String>(); + for (int i = 0; i < 10; ++i) { + newMap.put(i, String.valueOf(i)); + } + ArrayMap mapCopy = new ArrayMap(newMap); + if (!compare(mapCopy, newMap)) { + Log.e("test", "ArrayMap copy constructor failure: expected " + + newMap + ", got " + mapCopy); + dump(mHashMap, mArrayMap); + return; + } + Log.e("test", "Test successful; printing final map."); dump(mHashMap, mArrayMap); } + + private static boolean equalsTest() { + ArrayMap<Integer, String> map1 = new ArrayMap<Integer, String>(); + ArrayMap<Integer, String> map2 = new ArrayMap<Integer, String>(); + HashMap<Integer, String> map3 = new HashMap<Integer, String>(); + if (!compare(map1, map2) || !compare(map1, map3) || !compare(map3, map2)) { + Log.e("test", "ArrayMap equals failure for empty maps " + map1 + ", " + + map2 + ", " + map3); + return false; + } + + for (int i = 0; i < 10; ++i) { + String value = String.valueOf(i); + map1.put(i, value); + map2.put(i, value); + map3.put(i, value); + } + if (!compare(map1, map2) || !compare(map1, map3) || !compare(map3, map2)) { + Log.e("test", "ArrayMap equals failure for populated maps " + map1 + ", " + + map2 + ", " + map3); + return false; + } + + map1.remove(0); + if (compare(map1, map2) || compare(map1, map3) || compare(map3, map1)) { + Log.e("test", "ArrayMap equals failure for map size " + map1 + ", " + + map2 + ", " + map3); + return false; + } + + map1.put(0, "-1"); + if (compare(map1, map2) || compare(map1, map3) || compare(map3, map1)) { + Log.e("test", "ArrayMap equals failure for map contents " + map1 + ", " + + map2 + ", " + map3); + return false; + } + + return true; + } } |