summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNaveen Leekha <leekha@google.com>2015-09-22 18:04:44 -0700
committerNaveen Leekha <leekha@google.com>2015-09-22 18:04:44 -0700
commitb414255f53b560a06e642251535b019327ba0d7b (patch)
treef1e5d56cd14773002465200eff1c2de376c0fbc3
parent3a9b9aec7a0c04b74a278be5773fcfdaa2a04f4e (diff)
downloadframeworks_native-b414255f53b560a06e642251535b019327ba0d7b.zip
frameworks_native-b414255f53b560a06e642251535b019327ba0d7b.tar.gz
frameworks_native-b414255f53b560a06e642251535b019327ba0d7b.tar.bz2
Initialize local variables to avoid data leak
The uninitialized local variables pick up whatever the memory content was there on stack. This data gets sent to the remote process in case of a failed transaction, which is a security issue. Fixed. (Partial manual merge of master change 12ba0f57d028a9c8f4eb3afddc326b70677d1e0c. Rest to automerge from klp-dev) For b/23696300 Change-Id: I704c9fab327b3545c58e8a9a96ac542eb7469c2a
-rw-r--r--libs/gui/IGraphicBufferProducer.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/gui/IGraphicBufferProducer.cpp b/libs/gui/IGraphicBufferProducer.cpp
index 1e28f9b..dd9db33 100644
--- a/libs/gui/IGraphicBufferProducer.cpp
+++ b/libs/gui/IGraphicBufferProducer.cpp
@@ -344,7 +344,7 @@ status_t BnGraphicBufferProducer::onTransact(
CHECK_INTERFACE(IGraphicBufferProducer, data, reply);
sp<GraphicBuffer> buffer = new GraphicBuffer();
data.read(*buffer.get());
- int slot;
+ int slot = 0;
int result = attachBuffer(&slot, buffer);
reply->writeInt32(slot);
reply->writeInt32(result);