diff options
author | Mathias Agopian <mathias@google.com> | 2013-07-16 22:56:09 -0700 |
---|---|---|
committer | Mathias Agopian <mathias@google.com> | 2013-07-18 22:28:18 -0700 |
commit | 595264f1af12e25dce57d7c5b1d52ed86ac0d0c9 (patch) | |
tree | 204b340f3781aa95671fb08f47e53f51b125f57e /libs/gui/ConsumerBase.cpp | |
parent | 1962f6513732682645f74561c0665e168196056e (diff) | |
download | frameworks_native-595264f1af12e25dce57d7c5b1d52ed86ac0d0c9.zip frameworks_native-595264f1af12e25dce57d7c5b1d52ed86ac0d0c9.tar.gz frameworks_native-595264f1af12e25dce57d7c5b1d52ed86ac0d0c9.tar.bz2 |
BufferQueue improvements and APIs changes
this is the first step of a series of improvements to
BufferQueue. A few things happen in this change:
- setSynchronousMode() goes away as well as the SynchronousModeAllowed flag
- BufferQueue now defaults to (what used to be) synchronous mode
- a new "controlled by app" flag is passed when creating consumers and producers
those flags are used to put the BufferQueue in a mode where it
will never block if both flags are set. This is achieved by:
- returning an error from dequeueBuffer() if it would block
- making sure a buffer is always available by replacing
the previous buffer with the new one in queueBuffer()
(note: this is similar to what asynchrnous mode used to be)
Note: in this change EGL's swap-interval 0 is broken; this will be
fixed in another change.
Change-Id: I691f9507d6e2e158287e3039f2a79a4d4434211d
Diffstat (limited to 'libs/gui/ConsumerBase.cpp')
-rw-r--r-- | libs/gui/ConsumerBase.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libs/gui/ConsumerBase.cpp b/libs/gui/ConsumerBase.cpp index deb2646..cd94ce1 100644 --- a/libs/gui/ConsumerBase.cpp +++ b/libs/gui/ConsumerBase.cpp @@ -51,7 +51,7 @@ static int32_t createProcessUniqueId() { return android_atomic_inc(&globalCounter); } -ConsumerBase::ConsumerBase(const sp<BufferQueue>& bufferQueue) : +ConsumerBase::ConsumerBase(const sp<BufferQueue>& bufferQueue, bool controlledByApp) : mAbandoned(false), mBufferQueue(bufferQueue) { // Choose a name using the PID and a process-unique ID. @@ -66,7 +66,7 @@ ConsumerBase::ConsumerBase(const sp<BufferQueue>& bufferQueue) : listener = static_cast<BufferQueue::ConsumerListener*>(this); proxy = new BufferQueue::ProxyConsumerListener(listener); - status_t err = mBufferQueue->consumerConnect(proxy); + status_t err = mBufferQueue->consumerConnect(proxy, controlledByApp); if (err != NO_ERROR) { CB_LOGE("ConsumerBase: error connecting to BufferQueue: %s (%d)", strerror(-err), err); |