diff options
author | Mathias Agopian <mathias@google.com> | 2011-06-15 22:42:52 -0700 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2011-06-15 22:42:52 -0700 |
commit | e397ce2880020b7c04a711e481fc6faf8b52cecd (patch) | |
tree | 51284820a388ffca949bf1773e9ee8229d52395e /libs/utils | |
parent | dbe60ddd85abf4b18f3b9a97b33e0efa95b0dd8e (diff) | |
parent | 866f87251fb7163dcd4133b13b98510a871f3239 (diff) | |
download | frameworks_native-e397ce2880020b7c04a711e481fc6faf8b52cecd.zip frameworks_native-e397ce2880020b7c04a711e481fc6faf8b52cecd.tar.gz frameworks_native-e397ce2880020b7c04a711e481fc6faf8b52cecd.tar.bz2 |
am 0887b8c2: am 8e18668d: revert surfaceflinger leak fix as it uncovered a crasher on xoom (DO NOT MERGE)
* commit '0887b8c2e583e682cd2c1bc909cb3fdbec704004':
revert surfaceflinger leak fix as it uncovered a crasher on xoom (DO NOT MERGE)
Diffstat (limited to 'libs/utils')
-rw-r--r-- | libs/utils/RefBase.cpp | 44 |
1 files changed, 9 insertions, 35 deletions
diff --git a/libs/utils/RefBase.cpp b/libs/utils/RefBase.cpp index 8db2009..2034486 100644 --- a/libs/utils/RefBase.cpp +++ b/libs/utils/RefBase.cpp @@ -49,11 +49,6 @@ namespace android { // --------------------------------------------------------------------------- -RefBase::Destroyer::~Destroyer() { -} - -// --------------------------------------------------------------------------- - class RefBase::weakref_impl : public RefBase::weakref_type { public: @@ -61,7 +56,7 @@ public: volatile int32_t mWeak; RefBase* const mBase; volatile int32_t mFlags; - Destroyer* mDestroyer; + #if !DEBUG_REFS @@ -70,7 +65,6 @@ public: , mWeak(0) , mBase(base) , mFlags(0) - , mDestroyer(0) { } @@ -363,11 +357,7 @@ void RefBase::decStrong(const void* id) const if (c == 1) { const_cast<RefBase*>(this)->onLastStrongRef(id); if ((refs->mFlags&OBJECT_LIFETIME_WEAK) != OBJECT_LIFETIME_WEAK) { - if (refs->mDestroyer) { - refs->mDestroyer->destroy(this); - } else { - delete this; - } + delete this; } } refs->decWeak(id); @@ -400,9 +390,7 @@ int32_t RefBase::getStrongCount() const return mRefs->mStrong; } -void RefBase::setDestroyer(RefBase::Destroyer* destroyer) { - mRefs->mDestroyer = destroyer; -} + RefBase* RefBase::weakref_type::refBase() const { @@ -426,28 +414,16 @@ void RefBase::weakref_type::decWeak(const void* id) if (c != 1) return; if ((impl->mFlags&OBJECT_LIFETIME_WEAK) != OBJECT_LIFETIME_WEAK) { - if (impl->mStrong == INITIAL_STRONG_VALUE) { - if (impl->mBase) { - if (impl->mDestroyer) { - impl->mDestroyer->destroy(impl->mBase); - } else { - delete impl->mBase; - } - } - } else { + if (impl->mStrong == INITIAL_STRONG_VALUE) + delete impl->mBase; + else { // LOGV("Freeing refs %p of old RefBase %p\n", this, impl->mBase); delete impl; } } else { impl->mBase->onLastWeakRef(id); if ((impl->mFlags&OBJECT_LIFETIME_FOREVER) != OBJECT_LIFETIME_FOREVER) { - if (impl->mBase) { - if (impl->mDestroyer) { - impl->mDestroyer->destroy(impl->mBase); - } else { - delete impl->mBase; - } - } + delete impl->mBase; } } } @@ -569,10 +545,8 @@ RefBase::RefBase() RefBase::~RefBase() { - if ((mRefs->mFlags & OBJECT_LIFETIME_WEAK) == OBJECT_LIFETIME_WEAK) { - if (mRefs->mWeak == 0) { - delete mRefs; - } + if (mRefs->mWeak == 0) { + delete mRefs; } } |