summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorTatenda Chipeperekwa <tatendac@codeaurora.org>2015-10-13 15:14:51 -0700
committerSteve Kondik <steve@cyngn.com>2016-01-08 21:01:02 -0800
commitcda438d95ef30815323fb61fb43130a63d48193f (patch)
treed5b85f24bd5aad86dce986f855d93d53797dad9f /services
parentfd95bb1c240eea33b0c491b1b569091d4f3d7525 (diff)
downloadframeworks_native-cda438d95ef30815323fb61fb43130a63d48193f.zip
frameworks_native-cda438d95ef30815323fb61fb43130a63d48193f.tar.gz
frameworks_native-cda438d95ef30815323fb61fb43130a63d48193f.tar.bz2
sf: Change log message in layer query method from ALOGE to ALOGW
This error can be seen for the following use case 1. Connect HDMI display 2. Dump the SurfaceFlinger state The problem here is that HWComposer would have processed the display connection event via the hotplug mechanism and considers that the external display is connected. However, SurfaceFlinger has not updated its internal state (mDisplays) since it will be waiting for the mStateLock to be release by the dump function. As a result, when the dump function invokes the getLayerSortedByZForHwcDisplay for the external display, we will end up seeing the error log message because SurfaceFlingers internal state has not yet been updated. We can move this to ALOGW since it is a non-fatal/recoverable state. CRs-Fixed: 914173 Change-Id: Ib0ba359ecd894dd463417ba57ba1f72c07b5833e
Diffstat (limited to 'services')
-rw-r--r--services/surfaceflinger/SurfaceFlinger.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 4051b38..b27fc2b 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -2958,7 +2958,7 @@ SurfaceFlinger::getLayerSortedByZForHwcDisplay(int id) {
}
}
if (dpy == NULL) {
- ALOGE("getLayerSortedByZForHwcDisplay: invalid hwc display id %d", id);
+ ALOGW("getLayerSortedByZForHwcDisplay: invalid hwc display id %d", id);
// Just use the primary display so we have something to return
dpy = getBuiltInDisplay(DisplayDevice::DISPLAY_PRIMARY);
}