diff options
author | Alex Ray <aray@google.com> | 2013-04-29 12:24:49 -0700 |
---|---|---|
committer | Alex Ray <aray@google.com> | 2013-04-29 14:16:57 -0700 |
commit | c16e56dd43643d9013a72ddc42ab08e72f485382 (patch) | |
tree | 977c9bff87b8c8623a227b2cfe2dd415f05190da /modules/camera/Camera.cpp | |
parent | 005c9da54402e28eab5b8d52b729268a94ef4d61 (diff) | |
download | hardware_libhardware-c16e56dd43643d9013a72ddc42ab08e72f485382.zip hardware_libhardware-c16e56dd43643d9013a72ddc42ab08e72f485382.tar.gz hardware_libhardware-c16e56dd43643d9013a72ddc42ab08e72f485382.tar.bz2 |
modules: camera: Add scoped trace helper
This c++ helper class is normally provided by frameworks/native's
libutils, but cannot be used from the context of a hardware module. For
now just add the required functionality locally in the hardware module.
Change-Id: I5b399cbeb1c017a95baf19456dbf20569e677fbe
Diffstat (limited to 'modules/camera/Camera.cpp')
-rw-r--r-- | modules/camera/Camera.cpp | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/modules/camera/Camera.cpp b/modules/camera/Camera.cpp index eeae41f..d477ef6 100644 --- a/modules/camera/Camera.cpp +++ b/modules/camera/Camera.cpp @@ -25,6 +25,7 @@ #define ATRACE_TAG (ATRACE_TAG_CAMERA | ATRACE_TAG_HAL) #include <cutils/trace.h> +#include "ScopedTrace.h" #include "Camera.h" @@ -62,11 +63,10 @@ Camera::~Camera() int Camera::open(const hw_module_t *module, hw_device_t **device) { ALOGI("%s:%d: Opening camera device", __func__, mId); - ATRACE_BEGIN(__func__); + CAMTRACE_CALL(); pthread_mutex_lock(&mMutex); if (mBusy) { pthread_mutex_unlock(&mMutex); - ATRACE_END(); ALOGE("%s:%d: Error! Camera device already opened", __func__, mId); return -EBUSY; } @@ -77,18 +77,16 @@ int Camera::open(const hw_module_t *module, hw_device_t **device) *device = &mDevice.common; pthread_mutex_unlock(&mMutex); - ATRACE_END(); return 0; } int Camera::close() { ALOGI("%s:%d: Closing camera device", __func__, mId); - ATRACE_BEGIN(__func__); + CAMTRACE_CALL(); pthread_mutex_lock(&mMutex); if (!mBusy) { pthread_mutex_unlock(&mMutex); - ATRACE_END(); ALOGE("%s:%d: Error! Camera device not open", __func__, mId); return -EINVAL; } @@ -97,7 +95,6 @@ int Camera::close() mBusy = false; pthread_mutex_unlock(&mMutex); - ATRACE_END(); return 0; } @@ -132,16 +129,14 @@ const camera_metadata_t* Camera::constructDefaultRequestSettings(int type) int Camera::processCaptureRequest(camera3_capture_request_t *request) { ALOGV("%s:%d: request=%p", __func__, mId, request); - ATRACE_BEGIN(__func__); + CAMTRACE_CALL(); if (request == NULL) { ALOGE("%s:%d: NULL request recieved", __func__, mId); - ATRACE_END(); return -EINVAL; } // TODO: verify request; submit request to hardware - ATRACE_END(); return 0; } |