diff options
| author | Zhijun He <zhijunhe@google.com> | 2013-09-17 16:51:06 -0700 |
|---|---|---|
| committer | Zhijun He <zhijunhe@google.com> | 2013-09-17 16:53:55 -0700 |
| commit | b3ac07c0028b0afe8f9b009e37af90ec9a697b44 (patch) | |
| tree | 91b266633f212153918ab6e6de9ede7e739cb619 /tests | |
| parent | cd996be7791b3f78e925532d5820da06d58cf635 (diff) | |
| download | hardware_libhardware-b3ac07c0028b0afe8f9b009e37af90ec9a697b44.zip hardware_libhardware-b3ac07c0028b0afe8f9b009e37af90ec9a697b44.tar.gz hardware_libhardware-b3ac07c0028b0afe8f9b009e37af90ec9a697b44.tar.bz2 | |
Camera2 Tests: fix some sanity checks
Remove the requirement of HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED and make and
fix some minor issues.
Bug: 10388724
Change-Id: I18f0ea60f87902d6c2bbaca53957a91953866c40
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/camera2/CameraMetadataTests.cpp | 12 | ||||
| -rw-r--r-- | tests/camera2/CameraModuleTests.cpp | 4 |
2 files changed, 6 insertions, 10 deletions
diff --git a/tests/camera2/CameraMetadataTests.cpp b/tests/camera2/CameraMetadataTests.cpp index 2923de9..eddc593 100644 --- a/tests/camera2/CameraMetadataTests.cpp +++ b/tests/camera2/CameraMetadataTests.cpp @@ -136,10 +136,6 @@ TEST_F(CameraMetadataTest, RequiredFormats) { EXPECT_TRUE( HasElementInArrayFromStaticTag(ANDROID_SCALER_AVAILABLE_FORMATS, - HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED)); - - EXPECT_TRUE( - HasElementInArrayFromStaticTag(ANDROID_SCALER_AVAILABLE_FORMATS, HAL_PIXEL_FORMAT_BLOB)); // JPEG if (getDeviceVersion() < CAMERA_DEVICE_API_VERSION_3_0) { @@ -169,9 +165,11 @@ TEST_F(CameraMetadataTest, SaneResolutions) { // Iff there are listed raw resolutions, the format should be available int rawResolutionsCount = GetEntryCountFromStaticTag(ANDROID_SCALER_AVAILABLE_RAW_SIZES); - EXPECT_EQ(rawResolutionsCount > 0, - HasElementInArrayFromStaticTag(ANDROID_SCALER_AVAILABLE_FORMATS, - HAL_PIXEL_FORMAT_RAW_SENSOR)); + if (rawResolutionsCount > 0) { + EXPECT_TRUE( + HasElementInArrayFromStaticTag(ANDROID_SCALER_AVAILABLE_FORMATS, + HAL_PIXEL_FORMAT_RAW_SENSOR)); + } // Required processed sizes. int processedSizeCount = diff --git a/tests/camera2/CameraModuleTests.cpp b/tests/camera2/CameraModuleTests.cpp index e01cea4..9bd65ec 100644 --- a/tests/camera2/CameraModuleTests.cpp +++ b/tests/camera2/CameraModuleTests.cpp @@ -80,9 +80,7 @@ TEST_F(CameraModuleTest, LoadModuleBadIndices) { int idx[] = { -1, mNumberOfCameras, mNumberOfCameras + 1 }; for (unsigned i = 0; i < sizeof(idx)/sizeof(idx[0]); ++i) { - // Since the initialization should fail at device open(), it doesn't - // matter which version of CameraNDevice is used here - mDevice = new Camera2Device(idx[i]); + CreateCamera(idx[i], &mDevice); status_t deviceInitializeCode = initializeDevice(idx[i]); EXPECT_NE(OK, deviceInitializeCode); EXPECT_EQ(-ENODEV, deviceInitializeCode) |