diff options
| author | Alessio Igor Bogani <abogani@texware.it> | 2010-03-01 14:10:56 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-20 13:21:31 -0700 |
| commit | 41f2c6e89cf4d412e4b20803f5feb2b9b1560476 (patch) | |
| tree | 127bcdb795b0efb9b6dd180200b77279253c6120 | |
| parent | d20db4b4e938aa8e4e5735b5a1b202de5800400e (diff) | |
| download | kernel_goldelico_gta04-41f2c6e89cf4d412e4b20803f5feb2b9b1560476.zip kernel_goldelico_gta04-41f2c6e89cf4d412e4b20803f5feb2b9b1560476.tar.gz kernel_goldelico_gta04-41f2c6e89cf4d412e4b20803f5feb2b9b1560476.tar.bz2 | |
USB: sisusbvga: Remove the BKL from ioctl
Seems to me that BKL is not needed here because necessary locking is already
provided by mutex sisusb->lock.
Also change the returned value to long.
Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/misc/sisusbvga/sisusb.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c index aae95a0..63a6070 100644 --- a/drivers/usb/misc/sisusbvga/sisusb.c +++ b/drivers/usb/misc/sisusbvga/sisusb.c @@ -2974,13 +2974,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) struct sisusb_usb_data *sisusb; struct sisusb_info x; struct sisusb_command y; - int retval = 0; + long retval = 0; u32 __user *argp = (u32 __user *)arg; if (!(sisusb = (struct sisusb_usb_data *)file->private_data)) return -ENODEV; - lock_kernel(); mutex_lock(&sisusb->lock); /* Sanity check */ @@ -3039,7 +3038,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) err_out: mutex_unlock(&sisusb->lock); - unlock_kernel(); return retval; } |