diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-12 05:06:47 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-09-13 17:05:17 -0400 |
| commit | 7f2e6a5d8608d0353b017a0fe15502307593734e (patch) | |
| tree | 62f49c3e8f34bcdbf8869033e92aafc0ca4b84ef | |
| parent | 5744dd9b71c6b9df944c6a32a000d4a564a2abd7 (diff) | |
| download | kernel_goldelico_gta04-7f2e6a5d8608d0353b017a0fe15502307593734e.zip kernel_goldelico_gta04-7f2e6a5d8608d0353b017a0fe15502307593734e.tar.gz kernel_goldelico_gta04-7f2e6a5d8608d0353b017a0fe15502307593734e.tar.bz2 | |
drivers/isdn/gigaset/common.c: Remove useless kfree
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@
if (x@p1 == NULL) { ... when != I(x,...) S
when != e = e1
when != e += e1
when != e -= e1
when != ++e
when != --e
when != e++
when != e--
when != &e
kfree@p2(x); ... return ...; }
@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@
... when != true x@p1 == NULL
kfree@p2(x);
@depends on !ok && unchanged@
position r.p2;
expression x;
@@
*kfree@p2(x);
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/isdn/gigaset/common.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index aa41485..30a6b17 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors, return drv; error: - kfree(drv->cs); kfree(drv); return NULL; } |