diff options
| author | Jesper Juhl <jesper.juhl@gmail.com> | 2007-07-31 00:39:05 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-31 15:39:41 -0700 |
| commit | 80cd69203c3ad5f2ecf7d01cec4a10ed15613682 (patch) | |
| tree | 8328a64144dcf726e9b7b16c26f7fb5e10ee56a9 | |
| parent | 73c21e8024296760c450a0bded131cb573f83328 (diff) | |
| download | kernel_goldelico_gta04-80cd69203c3ad5f2ecf7d01cec4a10ed15613682.zip kernel_goldelico_gta04-80cd69203c3ad5f2ecf7d01cec4a10ed15613682.tar.gz kernel_goldelico_gta04-80cd69203c3ad5f2ecf7d01cec4a10ed15613682.tar.bz2 | |
ipmi: Fix mem leak in try_init_dmi()
This is only called at init time and only happens if the BIOS screws
something up, so the leak is slight and it is probably not worth sending to
2.6.22.x. The driver would not initialize the interface in the case, and I
have no reports of this happening. I have booted and run tests on a system
with this patch. Note that the original patch was munged by the mailer,
here's a new one.
If we ever hit the "default:" case in the switch in try_init_dmi(),
then we'll leak the storage allocated with kzalloc() and assigned
to 'info'.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_intf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 4edfdda..96d2f9e 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -2050,6 +2050,7 @@ static __devinit void try_init_dmi(struct dmi_ipmi_data *ipmi_data) info->si_type = SI_BT; break; default: + kfree(info); return; } |