aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/dc395x.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-02-11 22:03:18 +0300
committerJames Bottomley <JBottomley@Parallels.com>2013-02-24 09:29:34 +0000
commit208afec4f3be8c51ad6eebe6611dd6d2ad2fa298 (patch)
treea06e762057b8a23ae4f9f2f1e74000592a1aa032 /drivers/scsi/dc395x.c
parent4d24834dfd25f2dab5977241cd5a6662edde92f7 (diff)
downloadkernel_goldelico_gta04-208afec4f3be8c51ad6eebe6611dd6d2ad2fa298.zip
kernel_goldelico_gta04-208afec4f3be8c51ad6eebe6611dd6d2ad2fa298.tar.gz
kernel_goldelico_gta04-208afec4f3be8c51ad6eebe6611dd6d2ad2fa298.tar.bz2
[SCSI] dc395x: uninitialized variable in device_alloc()
This bug was introduced back in bitkeeper days in 2003. We use "dcb->dev_mode" before it has been initialized. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Oliver Neukum <oliver@neukum.org> Cc: <stable@vger.kernel.org> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/dc395x.c')
-rw-r--r--drivers/scsi/dc395x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 865c64f..fed486bf 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -3747,13 +3747,13 @@ static struct DeviceCtlBlk *device_alloc(struct AdapterCtlBlk *acb,
dcb->max_command = 1;
dcb->target_id = target;
dcb->target_lun = lun;
+ dcb->dev_mode = eeprom->target[target].cfg0;
#ifndef DC395x_NO_DISCONNECT
dcb->identify_msg =
IDENTIFY(dcb->dev_mode & NTC_DO_DISCONNECT, lun);
#else
dcb->identify_msg = IDENTIFY(0, lun);
#endif
- dcb->dev_mode = eeprom->target[target].cfg0;
dcb->inquiry7 = 0;
dcb->sync_mode = 0;
dcb->min_nego_period = clock_period[period_index];