diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2012-09-26 10:28:58 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-26 14:13:19 -0700 |
| commit | 1994ff405e9c1a8916ca41e093e786262af42b42 (patch) | |
| tree | e90693e5ee89e896a2d64468c6ed84d5509f92b5 /drivers/usb/storage | |
| parent | 0a2314035cab62cafc38ea11ec5b6f95cf347b38 (diff) | |
| download | kernel_goldelico_gta04-1994ff405e9c1a8916ca41e093e786262af42b42.zip kernel_goldelico_gta04-1994ff405e9c1a8916ca41e093e786262af42b42.tar.gz kernel_goldelico_gta04-1994ff405e9c1a8916ca41e093e786262af42b42.tar.bz2 | |
USB: uas: fix locking
Forgot to unlock in the uas_eh_task_mgmt error paths.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/storage')
| -rw-r--r-- | drivers/usb/storage/uas.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 1578909..4218701 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -649,12 +649,14 @@ static int uas_eh_task_mgmt(struct scsi_cmnd *cmnd, shost_printk(KERN_INFO, shost, "%s: %s: submit sense urb failed\n", __func__, fname); + spin_unlock_irqrestore(&devinfo->lock, flags); return FAILED; } if (uas_submit_task_urb(cmnd, GFP_ATOMIC, function, tag)) { shost_printk(KERN_INFO, shost, "%s: %s: submit task mgmt urb failed\n", __func__, fname); + spin_unlock_irqrestore(&devinfo->lock, flags); return FAILED; } spin_unlock_irqrestore(&devinfo->lock, flags); |