diff options
| author | Julia Lawall <julia@diku.dk> | 2008-11-19 15:36:41 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-11-19 18:49:59 -0800 |
| commit | c0d861afa5c986f7fe23647fbe411cd300f7c927 (patch) | |
| tree | 16a59ba410b80782eceaad7c63ad571aa4d99020 /drivers/video/backlight | |
| parent | f9454548e17cd56bad081bd7d55a09b001950cbb (diff) | |
| download | kernel_goldelico_gta04-c0d861afa5c986f7fe23647fbe411cd300f7c927.zip kernel_goldelico_gta04-c0d861afa5c986f7fe23647fbe411cd300f7c927.tar.gz kernel_goldelico_gta04-c0d861afa5c986f7fe23647fbe411cd300f7c927.tar.bz2 | |
drivers/video/backlight/da903x.c: introduce missing kfree
Error handling code following a kzalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@
(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
when != if (...) { <+...x...+> }
x->f = E
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Mike Rapoport <mike@compulab.co.il>
Cc: Richard Purdie <rpurdie@linux.intel.com>
Cc: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/backlight')
| -rw-r--r-- | drivers/video/backlight/da903x.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/video/backlight/da903x.c b/drivers/video/backlight/da903x.c index 242c382..75388b9 100644 --- a/drivers/video/backlight/da903x.c +++ b/drivers/video/backlight/da903x.c @@ -119,6 +119,7 @@ static int da903x_backlight_probe(struct platform_device *pdev) default: dev_err(&pdev->dev, "invalid backlight device ID(%d)\n", pdev->id); + kfree(data); return -EINVAL; } |