diff options
| author | KaiGai Kohei <kaigai@ak.jp.nec.com> | 2006-07-02 15:13:46 +0100 |
|---|---|---|
| committer | David Woodhouse <dwmw2@infradead.org> | 2006-07-02 15:13:46 +0100 |
| commit | c7afb0f97700e73109564f83c35bfeeb14cb653b (patch) | |
| tree | bd1c0f0e3b095e0dea15d569967a50703e05586e /fs/jffs2/acl.c | |
| parent | c05d52c748da10a3f27f6e638875514153776b15 (diff) | |
| download | kernel_goldelico_gta04-c7afb0f97700e73109564f83c35bfeeb14cb653b.zip kernel_goldelico_gta04-c7afb0f97700e73109564f83c35bfeeb14cb653b.tar.gz kernel_goldelico_gta04-c7afb0f97700e73109564f83c35bfeeb14cb653b.tar.bz2 | |
[JFFS2][XATTR] Fix memory leak in POSIX-ACL support
jffs2_clear_acl() which releases acl caches allocated by kmalloc()
was defined but it was never called. Thus, we faced to the risk
of memory leaking.
This patch plugs jffs2_clear_acl() into jffs2_do_clear_inode().
It ensures to release acl cache when inode is cleared.
Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'fs/jffs2/acl.c')
| -rw-r--r-- | fs/jffs2/acl.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c index 9c2077e..0ae3cd1 100644 --- a/fs/jffs2/acl.c +++ b/fs/jffs2/acl.c @@ -345,10 +345,8 @@ int jffs2_init_acl(struct inode *inode, struct inode *dir) return rc; } -void jffs2_clear_acl(struct inode *inode) +void jffs2_clear_acl(struct jffs2_inode_info *f) { - struct jffs2_inode_info *f = JFFS2_INODE_INFO(inode); - if (f->i_acl_access && f->i_acl_access != JFFS2_ACL_NOT_CACHED) { posix_acl_release(f->i_acl_access); f->i_acl_access = JFFS2_ACL_NOT_CACHED; |