diff options
| author | Christoph Hellwig <hch@lst.de> | 2009-05-05 15:40:36 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
| commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
| tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/jffs2/super.c | |
| parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) | |
| download | kernel_goldelico_gta04-6cfd0148425e528b859b26e436b01f23f6926224.zip kernel_goldelico_gta04-6cfd0148425e528b859b26e436b01f23f6926224.tar.gz kernel_goldelico_gta04-6cfd0148425e528b859b26e436b01f23f6926224.tar.bz2 | |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/jffs2/super.c')
| -rw-r--r-- | fs/jffs2/super.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index 5059e96..37b1212 100644 --- a/fs/jffs2/super.c +++ b/fs/jffs2/super.c @@ -174,6 +174,8 @@ static void jffs2_put_super (struct super_block *sb) D2(printk(KERN_DEBUG "jffs2: jffs2_put_super()\n")); + lock_kernel(); + if (sb->s_dirt) jffs2_write_super(sb); @@ -195,6 +197,8 @@ static void jffs2_put_super (struct super_block *sb) if (c->mtd->sync) c->mtd->sync(c->mtd); + unlock_kernel(); + D1(printk(KERN_DEBUG "jffs2_put_super returning\n")); } |