aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfsd/nfssvc.c
diff options
context:
space:
mode:
authorDavid Jeffery <djeffery@redhat.com>2013-07-10 13:19:50 -0400
committerJ. Bruce Fields <bfields@redhat.com>2013-07-11 17:24:07 -0400
commit1c327d962fc420aea046c16215a552710bde8231 (patch)
tree2ab025c8b577d7fe338b1530bea72c3fa0ef0d72 /fs/nfsd/nfssvc.c
parentd109148111cdfcdae94f797dc142468bd0ff7557 (diff)
downloadkernel_goldelico_gta04-1c327d962fc420aea046c16215a552710bde8231.zip
kernel_goldelico_gta04-1c327d962fc420aea046c16215a552710bde8231.tar.gz
kernel_goldelico_gta04-1c327d962fc420aea046c16215a552710bde8231.tar.bz2
lockd: protect nlm_blocked access in nlmsvc_retry_blocked
In nlmsvc_retry_blocked, the check that the list is non-empty and acquiring the pointer of the first entry is unprotected by any lock. This allows a rare race condition when there is only one entry on the list. A function such as nlmsvc_grant_callback() can be called, which will temporarily remove the entry from the list. Between the list_empty() and list_entry(),the list may become empty, causing an invalid pointer to be used as an nlm_block, leading to a possible crash. This patch adds the nlm_block_lock around these calls to prevent concurrent use of the nlm_blocked list. This was a regression introduced by f904be9cc77f361d37d71468b13ff3d1a1823dea "lockd: Mostly remove BKL from the server". Cc: Bryan Schumaker <bjschuma@netapp.com> Cc: stable@vger.kernel.org Signed-off-by: David Jeffery <djeffery@redhat.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/nfssvc.c')
0 files changed, 0 insertions, 0 deletions