aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_extfree_item.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2013-05-20 09:51:09 +1000
committerBen Myers <bpm@sgi.com>2013-05-20 14:25:50 -0500
commit28ca489c63e9aceed8801d2f82d731b3c9aa50f5 (patch)
treeef76b419c060971a615be94b00951a334c742067 /fs/xfs/xfs_extfree_item.c
parent49b137cbbcc836ef231866c137d24f42c42bb483 (diff)
downloadkernel_goldelico_gta04-28ca489c63e9aceed8801d2f82d731b3c9aa50f5.zip
kernel_goldelico_gta04-28ca489c63e9aceed8801d2f82d731b3c9aa50f5.tar.gz
kernel_goldelico_gta04-28ca489c63e9aceed8801d2f82d731b3c9aa50f5.tar.bz2
xfs: fix rounding in xfs_free_file_space
The offset passed into xfs_free_file_space() needs to be rounded down to a certain size, but the rounding mask is built by a 32 bit variable. Hence the mask will always mask off the upper 32 bits of the offset and lead to incorrect writeback and invalidation ranges. This is not actually exposed as a bug because we writeback and invalidate from the rounded offset to the end of the file, and hence the offset we are actually punching a hole out of will always be covered by the code. This needs fixing, however, if we ever want to use exact ranges for writeback/invalidation here... Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_extfree_item.c')
0 files changed, 0 insertions, 0 deletions