aboutsummaryrefslogtreecommitdiffstats
path: root/include/net
diff options
context:
space:
mode:
authorXi Wang <xi.wang@gmail.com>2011-12-27 09:43:19 +0000
committerDavid S. Miller <davem@davemloft.net>2011-12-28 14:08:08 -0500
commitba1cffe0257bcd4d0070bc0e64f8ead97fefd148 (patch)
tree5584b7816f7eb46953611ec35628c6924ea5a2af /include/net
parentfa84309533025eb3f03dc1d2d2be1c3ca206882a (diff)
downloadkernel_goldelico_gta04-ba1cffe0257bcd4d0070bc0e64f8ead97fefd148.zip
kernel_goldelico_gta04-ba1cffe0257bcd4d0070bc0e64f8ead97fefd148.tar.gz
kernel_goldelico_gta04-ba1cffe0257bcd4d0070bc0e64f8ead97fefd148.tar.bz2
ax25: avoid overflows in ax25_setsockopt()
Commit be639ac6 ("NET: AX.25: Check ioctl arguments to avoid overflows further down the road") rejects very large arguments, but doesn't completely fix overflows on 64-bit systems. Consider the AX25_T2 case. int opt; ... if (opt < 1 || opt > ULONG_MAX / HZ) { res = -EINVAL; break; } ax25->t2 = opt * HZ; The 32-bit multiplication opt * HZ would overflow before being assigned to 64-bit ax25->t2. This patch changes "opt" to unsigned long. Signed-off-by: Xi Wang <xi.wang@gmail.com> Cc: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
0 files changed, 0 insertions, 0 deletions