aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorJohn Fastabend <john.r.fastabend@intel.com>2012-02-10 03:19:41 +0000
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2012-03-02 18:16:49 -0800
commit2b88f2de30510c0f4e623d3cd5fcd85cdb70b51f (patch)
treecd267474e31962d04cedb175c4bf897031891dc8 /include
parent89d27a3c0ad7d5f2ce9ece055b3c7c619dc42f6c (diff)
downloadkernel_goldelico_gta04-2b88f2de30510c0f4e623d3cd5fcd85cdb70b51f.zip
kernel_goldelico_gta04-2b88f2de30510c0f4e623d3cd5fcd85cdb70b51f.tar.gz
kernel_goldelico_gta04-2b88f2de30510c0f4e623d3cd5fcd85cdb70b51f.tar.bz2
net: dcb: getnumtcs()/setnumtcs() should return an int
{g|s}etnumtcs() today returns a u8 that is only used by the DCB code to verify no error occurred. Today the driver implementations return negative error codes which end up being non-zero so the logic works out but triggers some sparse warnings. To fix the sparse warnings convert the return value to an int. CC: Eilon Greenstein <eilong@broadcom.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: John Fastabend <john.r.fastabend@intel.com> Tested-by: Ross Brattain <ross.b.brattain@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'include')
-rw-r--r--include/net/dcbnl.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/net/dcbnl.h b/include/net/dcbnl.h
index 2cd66d0..f55c980 100644
--- a/include/net/dcbnl.h
+++ b/include/net/dcbnl.h
@@ -72,8 +72,8 @@ struct dcbnl_rtnl_ops {
void (*getpfccfg)(struct net_device *, int, u8 *);
u8 (*setall)(struct net_device *);
u8 (*getcap)(struct net_device *, int, u8 *);
- u8 (*getnumtcs)(struct net_device *, int, u8 *);
- u8 (*setnumtcs)(struct net_device *, int, u8);
+ int (*getnumtcs)(struct net_device *, int, u8 *);
+ int (*setnumtcs)(struct net_device *, int, u8);
u8 (*getpfcstate)(struct net_device *);
void (*setpfcstate)(struct net_device *, u8);
void (*getbcncfg)(struct net_device *, int, u32 *);