diff options
| author | Paul E. McKenney <paul.mckenney@linaro.org> | 2012-08-13 11:17:06 -0700 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2012-09-23 07:42:51 -0700 |
| commit | c96ea7cfdd88d0a67c970502bc5313fede34b86b (patch) | |
| tree | b5e8273bfa99f3ddf72e3a4fbfb6483b60d7f345 /kernel/rcutree.c | |
| parent | c8020a67e625c714c4dbedc8ae2944b461e204ec (diff) | |
| download | kernel_goldelico_gta04-c96ea7cfdd88d0a67c970502bc5313fede34b86b.zip kernel_goldelico_gta04-c96ea7cfdd88d0a67c970502bc5313fede34b86b.tar.gz kernel_goldelico_gta04-c96ea7cfdd88d0a67c970502bc5313fede34b86b.tar.bz2 | |
rcu: Avoid spurious RCU CPU stall warnings
If a given CPU avoids the idle loop but also avoids starting a new
RCU grace period for a full minute, RCU can issue spurious RCU CPU
stall warnings. This commit fixes this issue by adding a check for
ongoing grace period to avoid these spurious stall warnings.
Reported-by: Becky Bruce <bgillbruce@gmail.com>
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Diffstat (limited to 'kernel/rcutree.c')
| -rw-r--r-- | kernel/rcutree.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/rcutree.c b/kernel/rcutree.c index 2cf8eb3..98f2752 100644 --- a/kernel/rcutree.c +++ b/kernel/rcutree.c @@ -819,7 +819,8 @@ static void check_cpu_stall(struct rcu_state *rsp, struct rcu_data *rdp) j = ACCESS_ONCE(jiffies); js = ACCESS_ONCE(rsp->jiffies_stall); rnp = rdp->mynode; - if ((ACCESS_ONCE(rnp->qsmask) & rdp->grpmask) && ULONG_CMP_GE(j, js)) { + if (rcu_gp_in_progress(rsp) && + (ACCESS_ONCE(rnp->qsmask) & rdp->grpmask) && ULONG_CMP_GE(j, js)) { /* We haven't checked in, so go dump stack. */ print_cpu_stall(rsp); |