diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2012-09-14 18:31:23 +0200 |
|---|---|---|
| committer | Oleg Nesterov <oleg@redhat.com> | 2012-09-29 21:21:52 +0200 |
| commit | 0578a97098dab967ece4b025fe5eb4984c4c86c0 (patch) | |
| tree | cf48aeca0e414d1eb2cafdfd28e8e31282a58af1 /kernel/trace/trace_nop.c | |
| parent | 746a9e6ba24af2ccf03279c99d435a1b88ca5d17 (diff) | |
| download | kernel_goldelico_gta04-0578a97098dab967ece4b025fe5eb4984c4c86c0.zip kernel_goldelico_gta04-0578a97098dab967ece4b025fe5eb4984c4c86c0.tar.gz kernel_goldelico_gta04-0578a97098dab967ece4b025fe5eb4984c4c86c0.tar.bz2 | |
uprobes: Fix UPROBE_SKIP_SSTEP checks in handle_swbp()
If handle_swbp()->add_utask() fails but UPROBE_SKIP_SSTEP is set,
cleanup_ret: path do not restart the insn, this is wrong. Remove
this check and add the additional label for can_skip_sstep() = T
case.
Note also that UPROBE_SKIP_SSTEP can be false positive, we simply
can not trust it unless arch_uprobe_skip_sstep() was already called.
Also, move another UPROBE_SKIP_SSTEP check before can_skip_sstep()
into this helper, this looks more clean and understandable.
Note: probably we should rename "skip" to "emulate" and I think
that "clear UPROBE_SKIP_SSTEP" should be moved to arch_can_skip.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/trace/trace_nop.c')
0 files changed, 0 insertions, 0 deletions