diff options
| author | Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de> | 2008-10-15 22:03:12 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-16 11:21:40 -0700 |
| commit | 3d599d1ca57f443e5c4ff5af1e69d90350082f77 (patch) | |
| tree | 475b066c18f2b610d6a0ee0a6313237ce61afc4a | |
| parent | c557fa3e4c156b8713c177d9dde08920130bf551 (diff) | |
| download | kernel_samsung_aries-3d599d1ca57f443e5c4ff5af1e69d90350082f77.zip kernel_samsung_aries-3d599d1ca57f443e5c4ff5af1e69d90350082f77.tar.gz kernel_samsung_aries-3d599d1ca57f443e5c4ff5af1e69d90350082f77.tar.bz2 | |
gpio_free might sleep, generic part
According to the documentation gpio_free should only be called from task
context only. To make this more explicit add a might sleep to all
implementations.
This is the generic part which changes gpiolib and the fallback
implementation only.
Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/gpio/gpiolib.c | 2 | ||||
| -rw-r--r-- | include/linux/gpio.h | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 8d29405..317004f 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -792,6 +792,8 @@ void gpio_free(unsigned gpio) unsigned long flags; struct gpio_desc *desc; + might_sleep(); + if (!gpio_is_valid(gpio)) { WARN_ON(extra_checks); return; diff --git a/include/linux/gpio.h b/include/linux/gpio.h index 730a20b..e10c49a 100644 --- a/include/linux/gpio.h +++ b/include/linux/gpio.h @@ -8,6 +8,7 @@ #else +#include <linux/kernel.h> #include <linux/types.h> #include <linux/errno.h> @@ -32,6 +33,8 @@ static inline int gpio_request(unsigned gpio, const char *label) static inline void gpio_free(unsigned gpio) { + might_sleep(); + /* GPIO can never have been requested */ WARN_ON(1); } |