aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-12-23 19:17:34 +0000
committerDavid S. Miller <davem@davemloft.net>2010-12-28 13:54:57 -0800
commit4a5fc4e179d79c79ad87bfc12a2d7e9b2371e40c (patch)
treec8d5aa6ca5080097c2927295b6560668e17eca0b
parentd39cd5e99a0ad88aba6793fb5e5f34e29cda6e6f (diff)
downloadkernel_samsung_aries-4a5fc4e179d79c79ad87bfc12a2d7e9b2371e40c.zip
kernel_samsung_aries-4a5fc4e179d79c79ad87bfc12a2d7e9b2371e40c.tar.gz
kernel_samsung_aries-4a5fc4e179d79c79ad87bfc12a2d7e9b2371e40c.tar.bz2
skfp: testing the wrong variable in skfp_driver_init()
The intent here was to test if the allocation failed but we tested "SharedMemSize" instead of "SharedMemAddr" by mistake. Signed-off-by: Dan Carpenter <error27@gmail.com> Reviewed-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/skfp/skfddi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/skfp/skfddi.c b/drivers/net/skfp/skfddi.c
index 0a66fed..16c6265 100644
--- a/drivers/net/skfp/skfddi.c
+++ b/drivers/net/skfp/skfddi.c
@@ -412,7 +412,7 @@ static int skfp_driver_init(struct net_device *dev)
bp->SharedMemAddr = pci_alloc_consistent(&bp->pdev,
bp->SharedMemSize,
&bp->SharedMemDMA);
- if (!bp->SharedMemSize) {
+ if (!bp->SharedMemAddr) {
printk("could not allocate mem for ");
printk("hardware module: %ld byte\n",
bp->SharedMemSize);