aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2006-02-17 12:11:29 +0100
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>2006-02-27 21:26:45 -0600
commit938050916f57f08e20595b1fa1c1e57c2fbf7243 (patch)
tree461104c764c00d7824eaa7df8cba8d9cdd0dbb66
parent8b097a67264ba3e10620b268979de3be6fe5e3cd (diff)
downloadkernel_samsung_aries-938050916f57f08e20595b1fa1c1e57c2fbf7243.zip
kernel_samsung_aries-938050916f57f08e20595b1fa1c1e57c2fbf7243.tar.gz
kernel_samsung_aries-938050916f57f08e20595b1fa1c1e57c2fbf7243.tar.bz2
[SCSI] scsi: handle ->slave_configure return value
When ­>slave_configure fails the scsi midlayer should handle it. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r--drivers/scsi/scsi_scan.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 5acb83c..f9ecc3d 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -752,8 +752,20 @@ static int scsi_add_lun(struct scsi_device *sdev, char *inq_result, int *bflags)
transport_configure_device(&sdev->sdev_gendev);
- if (sdev->host->hostt->slave_configure)
- sdev->host->hostt->slave_configure(sdev);
+ if (sdev->host->hostt->slave_configure) {
+ int ret = sdev->host->hostt->slave_configure(sdev);
+ if (ret) {
+ /*
+ * if LLDD reports slave not present, don't clutter
+ * console with alloc failure messages
+ */
+ if (ret != -ENXIO) {
+ sdev_printk(KERN_ERR, sdev,
+ "failed to configure device\n");
+ }
+ return SCSI_SCAN_NO_RESPONSE;
+ }
+ }
/*
* Ok, the device is now all set up, we can