diff options
author | Rafael J. Wysocki <rjw@sisk.pl> | 2009-01-26 21:43:08 +0100 |
---|---|---|
committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2009-01-27 09:45:46 -0800 |
commit | 418e4da33f45fd7bdcce48778b149b780ff730bc (patch) | |
tree | fca80fd94c2ec3ce7c7384daa07c9783ed33d96a /arch/x86/pci/irq.c | |
parent | 5ee810072175042775e39bdd3eaaa68884c27805 (diff) | |
download | kernel_samsung_aries-418e4da33f45fd7bdcce48778b149b780ff730bc.zip kernel_samsung_aries-418e4da33f45fd7bdcce48778b149b780ff730bc.tar.gz kernel_samsung_aries-418e4da33f45fd7bdcce48778b149b780ff730bc.tar.bz2 |
PCI PM: Fix suspend error paths and testing facility breakage
If one of device drivers refuses to suspend by returning error code
from its ->suspend() callback, the devices that have already been
suspended are resumed by executing their drivers' ->resume()
callbacks. Some of these callbacks expect the device's
configuration space to be restored if the device has been put into
D3 before they are called. Unfortunately, this mechanism has been
broken by recent changes moving the restoration of config spaces
of some devices (most importantly, USB controllers and HDA Intel)
into the resume callbacks executed with interrupts off. Obviously,
these callbacks are not invoked in the suspend error path and, as a
result, the system cannot be successfully brought back into the
working state in case of a suspend error. The same thing happens
in the hibernation error path right before putting the system into
S4.
Similarly, the suspend testing facility associated with the
/sys/power/pm_test file is broken, because it uses the very same
mechanism that is used in the suspend and hibernation error paths.
Fix the breakage by making the PCI core restore the configuration
spaces of PCI devices that haven't been restored already before
pci_pm_resume() is called for those devices by the PM core.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'arch/x86/pci/irq.c')
0 files changed, 0 insertions, 0 deletions