diff options
author | tom.leiming@gmail.com <tom.leiming@gmail.com> | 2012-03-22 03:22:18 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-02 09:27:17 -0700 |
commit | 27c3e5f205c085075547cb376bdae37693bd7090 (patch) | |
tree | 5ad033404f5033a6052cad80e93abed06a638a7e /drivers/macintosh/windfarm_smu_sat.c | |
parent | 77d77ab09b1b57cf3cc30d0dbdf8c55137146a8f (diff) | |
download | kernel_samsung_aries-27c3e5f205c085075547cb376bdae37693bd7090.zip kernel_samsung_aries-27c3e5f205c085075547cb376bdae37693bd7090.tar.gz kernel_samsung_aries-27c3e5f205c085075547cb376bdae37693bd7090.tar.bz2 |
usbnet: increase URB reference count before usb_unlink_urb
commit 0956a8c20b23d429e79ff86d4325583fc06f9eb4 upstream.
Commit 4231d47e6fe69f061f96c98c30eaf9fb4c14b96d(net/usbnet: avoid
recursive locking in usbnet_stop()) fixes the recursive locking
problem by releasing the skb queue lock, but it makes usb_unlink_urb
racing with defer_bh, and the URB to being unlinked may be freed before
or during calling usb_unlink_urb, so use-after-free problem may be
triggerd inside usb_unlink_urb.
The patch fixes the use-after-free problem by increasing URB
reference count with skb queue lock held before calling
usb_unlink_urb, so the URB won't be freed until return from
usb_unlink_urb.
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oliver@neukum.org>
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/macintosh/windfarm_smu_sat.c')
0 files changed, 0 insertions, 0 deletions