diff options
| author | Bjørn Mork <bjorn@mork.no> | 2010-11-14 14:24:36 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-12-29 08:16:48 -0200 |
| commit | a22407faba57c3624beea1a9fad7cbdcf5a19a1a (patch) | |
| tree | f6e2af4ef614bb254858b5db60da3b70bcb25816 /drivers/media/dvb/mantis/mantis_vp3030.c | |
| parent | 9c81496a88b04206d0607b23b298b6529da1fcb0 (diff) | |
| download | kernel_samsung_aries-a22407faba57c3624beea1a9fad7cbdcf5a19a1a.zip kernel_samsung_aries-a22407faba57c3624beea1a9fad7cbdcf5a19a1a.tar.gz kernel_samsung_aries-a22407faba57c3624beea1a9fad7cbdcf5a19a1a.tar.bz2 | |
[media] Mantis: use dvb_attach to avoid double dereferencing on module removal
Convert the driver to use the dvb_attach macro to avoid the hard dependency
on the frontend drivers. The hard dependecy will result in loading a
number of unused frontends, and unwanted automatic dereferencing.
This fixes a bug where unloading the mantis driver will derefence any
attached frontend twice, which will cause an oops if the same frontend is
used by another driver.
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/dvb/mantis/mantis_vp3030.c')
| -rw-r--r-- | drivers/media/dvb/mantis/mantis_vp3030.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/dvb/mantis/mantis_vp3030.c b/drivers/media/dvb/mantis/mantis_vp3030.c index 1f43342..be4d87c 100644 --- a/drivers/media/dvb/mantis/mantis_vp3030.c +++ b/drivers/media/dvb/mantis/mantis_vp3030.c @@ -68,12 +68,12 @@ static int vp3030_frontend_init(struct mantis_pci *mantis, struct dvb_frontend * if (err == 0) { msleep(250); dprintk(MANTIS_ERROR, 1, "Probing for 10353 (DVB-T)"); - fe = zl10353_attach(&mantis_vp3030_config, adapter); + fe = dvb_attach(zl10353_attach, &mantis_vp3030_config, adapter); if (!fe) return -1; - tda665x_attach(fe, &env57h12d5_config, adapter); + dvb_attach(tda665x_attach, fe, &env57h12d5_config, adapter); } else { dprintk(MANTIS_ERROR, 1, "Frontend on <%s> POWER ON failed! <%d>", adapter->name, |