aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/time
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2013-05-03 15:02:50 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-05-19 10:04:40 -0700
commitb9cbfd27308999d2ae56d1d341a3a77f91d04a19 (patch)
treec0f7f5416753ce6cbd164952868a304c0b058f5a /kernel/time
parente8934286bc36b73db88a361d31f8eb617ee5cf03 (diff)
downloadkernel_samsung_aries-b9cbfd27308999d2ae56d1d341a3a77f91d04a19.zip
kernel_samsung_aries-b9cbfd27308999d2ae56d1d341a3a77f91d04a19.tar.gz
kernel_samsung_aries-b9cbfd27308999d2ae56d1d341a3a77f91d04a19.tar.bz2
tick: Cleanup NOHZ per cpu data on cpu down
commit 4b0c0f294f60abcdd20994a8341a95c8ac5eeb96 upstream. Prarit reported a crash on CPU offline/online. The reason is that on CPU down the NOHZ related per cpu data of the dead cpu is not cleaned up. If at cpu online an interrupt happens before the per cpu tick device is registered the irq_enter() check potentially sees stale data and dereferences a NULL pointer. Cleanup the data after the cpu is dead. Reported-by: Prarit Bhargava <prarit@redhat.com> Cc: Mike Galbraith <bitbucket@online.de> Link: http://lkml.kernel.org/r/alpine.LFD.2.02.1305031451561.2886@ionos Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/time')
-rw-r--r--kernel/time/tick-sched.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index c473ce2..c0be5f2 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -811,7 +811,7 @@ void tick_cancel_sched_timer(int cpu)
hrtimer_cancel(&ts->sched_timer);
# endif
- ts->nohz_mode = NOHZ_MODE_INACTIVE;
+ memset(ts, 0, sizeof(*ts));
}
#endif