diff options
| author | Michal Marek <mmarek@suse.cz> | 2010-01-08 12:25:37 +0100 |
|---|---|---|
| committer | Michal Marek <mmarek@suse.cz> | 2010-01-13 13:27:24 +0100 |
| commit | 07105202bdebf6e9a4c72c634cf90398abfad870 (patch) | |
| tree | 0eec6777ac1e7a4d1282b5434d1602eb7767edc8 | |
| parent | 1373411ae4cd0caf2e1a35fb801dd9a00b64dea2 (diff) | |
| download | kernel_samsung_crespo-07105202bdebf6e9a4c72c634cf90398abfad870.zip kernel_samsung_crespo-07105202bdebf6e9a4c72c634cf90398abfad870.tar.gz kernel_samsung_crespo-07105202bdebf6e9a4c72c634cf90398abfad870.tar.bz2 | |
Makefile: do not override LC_CTYPE
Setting LC_CTYPE=C breaks localized messages in some setups. With only
LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not
so defined character classes and tolower()/toupper(). The former is not
a big issue, because we can assume that e.g. [:alpha:] will always
include a-zA-Z and we only ever process ASCII input. The latter seems
only affect arch/sh/tools/gen-mach-types, which we can handle separately.
So after this patch the meaning of ranges like [a-z], the behavior of
sort and join, etc. should be the same everywhere and at the same time
gcc should be able to print localized waring and error messages.
LC_NUMERIC=C might not be necessary, but setting it doesn't hurt.
Reported-by: Simon Horman <horms@verge.net.au>
Reported-by: Sergei Trofimovich <slyfox@inbox.ru>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Tested-by: Simon Horman <horms@verge.net.au>
Tested-by: Masami Hiramatsu <mhiramat@redhat.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
| -rw-r--r-- | Makefile | 3 | ||||
| -rw-r--r-- | arch/sh/tools/Makefile | 2 |
2 files changed, 2 insertions, 3 deletions
@@ -18,10 +18,9 @@ MAKEFLAGS += -rR --no-print-directory # Avoid funny character set dependencies unexport LC_ALL -LC_CTYPE=C LC_COLLATE=C LC_NUMERIC=C -export LC_CTYPE LC_COLLATE LC_NUMERIC +export LC_COLLATE LC_NUMERIC # We are using a recursive build, so we need to do a little thinking # to get the ordering right. diff --git a/arch/sh/tools/Makefile b/arch/sh/tools/Makefile index 558a56b..2082af1 100644 --- a/arch/sh/tools/Makefile +++ b/arch/sh/tools/Makefile @@ -13,4 +13,4 @@ include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types @echo ' Generating $@' $(Q)mkdir -p $(dir $@) - $(Q)$(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } + $(Q)LC_ALL=C $(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } |