aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJP Abgrall <jpa@google.com>2012-08-28 16:53:32 -0700
committerandroid code review <noreply-gerritcodereview@google.com>2012-08-28 16:58:08 -0700
commit1dfbc281b4a77cd19dd65fa447a8567b3c0b93f2 (patch)
treecf549043da6d80be36ea242f1412d3142af484f1
parentddb45c7e8572c73ba6b0367dcd27ca4e2d5bcee4 (diff)
downloadkernel_samsung_crespo-1dfbc281b4a77cd19dd65fa447a8567b3c0b93f2.zip
kernel_samsung_crespo-1dfbc281b4a77cd19dd65fa447a8567b3c0b93f2.tar.gz
kernel_samsung_crespo-1dfbc281b4a77cd19dd65fa447a8567b3c0b93f2.tar.bz2
netfilter: xt_qtaguid: report only uid tags to non-privileged processes
In the past, a process could only see its own stats (uid-based summary, and details). Now we allow any process to see other UIDs uid-based stats, but still hide the detailed stats. Change-Id: I7666961ed244ac1d9359c339b048799e5db9facc Signed-off-by: JP Abgrall <jpa@google.com>
-rw-r--r--net/netfilter/xt_qtaguid.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c
index f6d4cfc..ea716b3 100644
--- a/net/netfilter/xt_qtaguid.c
+++ b/net/netfilter/xt_qtaguid.c
@@ -2588,8 +2588,9 @@ static int pp_stats_line(struct proc_print_info *ppi, int cnt_set)
} else {
tag_t tag = ppi->ts_entry->tn.tag;
uid_t stat_uid = get_uid_from_tag(tag);
-
- if (!can_read_other_uid_stats(stat_uid)) {
+ /* Detailed tags are not available to everybody */
+ if (get_atag_from_tag(tag)
+ && !can_read_other_uid_stats(stat_uid)) {
CT_DEBUG("qtaguid: stats line: "
"%s 0x%llx %u: insufficient priv "
"from pid=%u tgid=%u uid=%u\n",