diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2010-09-07 14:34:01 +0000 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2010-10-30 12:12:50 +0200 |
| commit | 4882720b267b7b1d1b0ce08334b205f0329d4615 (patch) | |
| tree | dd54880f84b7b7fb2bbdb529ffada434aca1e4d9 | |
| parent | 45f4d0243525b6bc747c946937ced437b135a84d (diff) | |
| download | kernel_samsung_crespo-4882720b267b7b1d1b0ce08334b205f0329d4615.zip kernel_samsung_crespo-4882720b267b7b1d1b0ce08334b205f0329d4615.tar.gz kernel_samsung_crespo-4882720b267b7b1d1b0ce08334b205f0329d4615.tar.bz2 | |
semaphore: Remove mutex emulation
Semaphores used as mutexes have been deprecated for years. Now that
all users are either converted to real semaphores or to mutexes remove
the cruft.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>
LKML-Reference: <20100907125057.562399240@linutronix.de>
| -rw-r--r-- | include/linux/semaphore.h | 6 | ||||
| -rwxr-xr-x | scripts/checkpatch.pl | 8 |
2 files changed, 2 insertions, 12 deletions
diff --git a/include/linux/semaphore.h b/include/linux/semaphore.h index 5310d27..39fa049 100644 --- a/include/linux/semaphore.h +++ b/include/linux/semaphore.h @@ -29,9 +29,6 @@ struct semaphore { #define DEFINE_SEMAPHORE(name) \ struct semaphore name = __SEMAPHORE_INITIALIZER(name, 1) -#define DECLARE_MUTEX(name) \ - struct semaphore name = __SEMAPHORE_INITIALIZER(name, 1) - static inline void sema_init(struct semaphore *sem, int val) { static struct lock_class_key __key; @@ -39,9 +36,6 @@ static inline void sema_init(struct semaphore *sem, int val) lockdep_init_map(&sem->lock.dep_map, "semaphore->lock", &__key, 0); } -#define init_MUTEX(sem) sema_init(sem, 1) -#define init_MUTEX_LOCKED(sem) sema_init(sem, 0) - extern void down(struct semaphore *sem); extern int __must_check down_interruptible(struct semaphore *sem); extern int __must_check down_killable(struct semaphore *sem); diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 90b54d4..e3c7fc0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2794,12 +2794,8 @@ sub process { WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); } -# check for semaphores used as mutexes - if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) { - WARN("mutexes are preferred for single holder semaphores\n" . $herecurr); - } -# check for semaphores used as mutexes - if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) { +# check for semaphores initialized locked + if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) { WARN("consider using a completion\n" . $herecurr); } |