diff options
| author | Pavel Roskin <proski@gnu.org> | 2012-02-11 10:01:53 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-02-29 16:34:28 -0800 |
| commit | 6778e220c09cdfb19a326192fd25ee146755b95d (patch) | |
| tree | 8637fd9630f314b8a7b4d710396d2d2e71fe6aa7 | |
| parent | 534b465e1cf6e3bbceebbc7866a204107b83eb95 (diff) | |
| download | kernel_samsung_crespo-6778e220c09cdfb19a326192fd25ee146755b95d.zip kernel_samsung_crespo-6778e220c09cdfb19a326192fd25ee146755b95d.tar.gz kernel_samsung_crespo-6778e220c09cdfb19a326192fd25ee146755b95d.tar.bz2 | |
ath9k: stop on rates with idx -1 in ath9k rate control's .tx_status
commit 2504a6423b9ab4c36df78227055995644de19edb upstream.
Rate control algorithms are supposed to stop processing when they
encounter a rate with the index -1. Checking for rate->count not being
zero is not enough.
Allowing a rate with negative index leads to memory corruption in
ath_debug_stat_rc().
One consequence of the bug is discussed at
https://bugzilla.redhat.com/show_bug.cgi?id=768639
Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/wireless/ath/ath9k/rc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c index ea35843..9d965e3 100644 --- a/drivers/net/wireless/ath/ath9k/rc.c +++ b/drivers/net/wireless/ath/ath9k/rc.c @@ -1328,7 +1328,7 @@ static void ath_tx_status(void *priv, struct ieee80211_supported_band *sband, fc = hdr->frame_control; for (i = 0; i < sc->hw->max_rates; i++) { struct ieee80211_tx_rate *rate = &tx_info->status.rates[i]; - if (!rate->count) + if (rate->idx < 0 || !rate->count) break; final_ts_idx = i; |