diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2011-02-10 10:58:45 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-02-13 11:21:15 -0800 |
| commit | ab60707ffe9920b66b4fff5181b44b14cd091472 (patch) | |
| tree | d0baa22dfe87b87b0188ac0305d05fa7454a5c3c | |
| parent | d3337de52af7fb0ebe605b02b740be4ee7dee9eb (diff) | |
| download | kernel_samsung_crespo-ab60707ffe9920b66b4fff5181b44b14cd091472.zip kernel_samsung_crespo-ab60707ffe9920b66b4fff5181b44b14cd091472.tar.gz kernel_samsung_crespo-ab60707ffe9920b66b4fff5181b44b14cd091472.tar.bz2 | |
USB Network driver infrastructure: Fix leak when usb_autopm_get_interface() returns less than zero in kevent().
We'll leak the memory allocated to 'urb' in
drivers/net/usb/usbnet.c:kevent() when we 'goto fail_lowmem' and the 'urb'
variable goes out of scope while still completely unused.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/usbnet.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index ed9a416..95c41d5 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -931,8 +931,10 @@ fail_halt: if (urb != NULL) { clear_bit (EVENT_RX_MEMORY, &dev->flags); status = usb_autopm_get_interface(dev->intf); - if (status < 0) + if (status < 0) { + usb_free_urb(urb); goto fail_lowmem; + } if (rx_submit (dev, urb, GFP_KERNEL) == -ENOLINK) resched = 0; usb_autopm_put_interface(dev->intf); |