aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/can
diff options
context:
space:
mode:
authorWolfram Sang <w.sang@pengutronix.de>2009-11-16 12:57:49 +0000
committerDavid S. Miller <davem@davemloft.net>2009-11-17 03:54:02 -0800
commit68bd7422a2e07a4e5502137cd4bddb8c2774a912 (patch)
tree0f42eee1a2057ddc18264df99b4d881e62bff6a7 /drivers/net/can
parent1712fe59415faf23a36c38dbacf18efd4ffe94e0 (diff)
downloadkernel_samsung_crespo-68bd7422a2e07a4e5502137cd4bddb8c2774a912.zip
kernel_samsung_crespo-68bd7422a2e07a4e5502137cd4bddb8c2774a912.tar.gz
kernel_samsung_crespo-68bd7422a2e07a4e5502137cd4bddb8c2774a912.tar.bz2
net/can/mscan: drop assignment in while-construct
As suggested by Wolfgang Grandegger. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/can')
-rw-r--r--drivers/net/can/mscan/mscan.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index 76e413e..20d1991 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -379,8 +379,10 @@ static int mscan_rx_poll(struct napi_struct *napi, int quota)
struct can_frame *frame;
u8 canrflg;
- while (npackets < quota && ((canrflg = in_8(&regs->canrflg)) &
- (MSCAN_RXF | MSCAN_ERR_IF))) {
+ while (npackets < quota) {
+ canrflg = in_8(&regs->canrflg);
+ if (!(canrflg & (MSCAN_RXF | MSCAN_ERR_IF)))
+ break;
skb = alloc_can_skb(dev, &frame);
if (!skb) {