aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/platform
diff options
context:
space:
mode:
authorAtsushi Nemoto <anemo@mba.ocn.ne.jp>2012-08-21 16:16:10 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-02 09:47:39 -0700
commitf20560e86297b92b4dff11cb2e6daa61b3f88368 (patch)
tree45d56bb843e8a0fdd19dcdd32dc7fb22d90b4e7d /drivers/platform
parentd0179ca85eb702e31c645556f4dc2e58a3af31f4 (diff)
downloadkernel_samsung_crespo-f20560e86297b92b4dff11cb2e6daa61b3f88368.zip
kernel_samsung_crespo-f20560e86297b92b4dff11cb2e6daa61b3f88368.tar.gz
kernel_samsung_crespo-f20560e86297b92b4dff11cb2e6daa61b3f88368.tar.bz2
drivers/rtc/rtc-rs5c348.c: fix hour decoding in 12-hour mode
commit 7dbfb315b2aaef0a115765946bf3026d074c33a7 upstream. Correct the offset by subtracting 20 from tm_hour before taking the modulo 12. [ "Why 20?" I hear you ask. Or at least I did. Here's the reason why: RS5C348_BIT_PM is 32, and is - stupidly - included in the RS5C348_HOURS_MASK define. So it's really subtracting out that bit to get "hour+12". But then because it does things modulo 12, it needs to add the 12 in again afterwards anyway. This code is confused. It would be much clearer if RS5C348_HOURS_MASK just didn't include the RS5C348_BIT_PM bit at all, then it wouldn't need to do the silly subtract either. Whatever. It's all just math, the end result is the same. - Linus ] Reported-by: James Nute <newten82@gmail.com> Tested-by: James Nute <newten82@gmail.com> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/platform')
0 files changed, 0 insertions, 0 deletions