diff options
| author | Ben Dooks <ben-linux@fluff.org> | 2008-04-15 14:34:44 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-15 19:35:41 -0700 |
| commit | 4bb5eba06b4bc57e30b0f6336c9907e85c395197 (patch) | |
| tree | e471e6c09b5aa148eef724bc7ffd04ec5e59c04e /drivers/spi/spi_s3c24xx.c | |
| parent | 335e92e8a515420bd47a6b0f01cb9a206c0ed6e4 (diff) | |
| download | kernel_samsung_crespo-4bb5eba06b4bc57e30b0f6336c9907e85c395197.zip kernel_samsung_crespo-4bb5eba06b4bc57e30b0f6336c9907e85c395197.tar.gz kernel_samsung_crespo-4bb5eba06b4bc57e30b0f6336c9907e85c395197.tar.bz2 | |
spi: spi_s3c24xx driver must init completion
The s3c24xx_spi_txrx() function should initialise the completion each time
before using it, otherwise we end up with the possibility of returning success
before the interrupt handler has processed all the data.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/spi/spi_s3c24xx.c')
| -rw-r--r-- | drivers/spi/spi_s3c24xx.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/spi/spi_s3c24xx.c b/drivers/spi/spi_s3c24xx.c index e75103a..6f2c79d 100644 --- a/drivers/spi/spi_s3c24xx.c +++ b/drivers/spi/spi_s3c24xx.c @@ -192,8 +192,11 @@ static int s3c24xx_spi_txrx(struct spi_device *spi, struct spi_transfer *t) hw->len = t->len; hw->count = 0; + init_completion(&hw->done); + /* send the first byte */ writeb(hw_txbyte(hw, 0), hw->regs + S3C2410_SPTDAT); + wait_for_completion(&hw->done); return hw->count; |