diff options
| author | Brett Russ <russb@emc.com> | 2005-09-01 21:53:34 -0400 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@pobox.com> | 2005-09-07 01:54:54 -0400 |
| commit | 7da79312830e6d9b3f6ee06b86c3a35caba2f6e7 (patch) | |
| tree | afd386f0cee850f62fdb9245105e02fe49631d28 /drivers | |
| parent | 4706df3d3c42af802597d82c8b1542c3d52eab23 (diff) | |
| download | kernel_samsung_crespo-7da79312830e6d9b3f6ee06b86c3a35caba2f6e7.zip kernel_samsung_crespo-7da79312830e6d9b3f6ee06b86c3a35caba2f6e7.tar.gz kernel_samsung_crespo-7da79312830e6d9b3f6ee06b86c3a35caba2f6e7.tar.bz2 | |
[PATCH] libata: fix pio_mask values (take 2)
ata_get_mode_mask() uses bits 3 and 4 in the pio_mask to represent PIO
modes 3 and 4. The value read from the drive, which reports support
for PIO3 and PIO4 in bits 0 and 1, is shifted left by 3 bits and OR'd
with 0x7 (which then corresponds to PIO 2-0 in libata). Thus, the
drivers below need adjustments to comply with the way pio_mask is
used. I changed the masks from the commented values to all support
PIO4-0, since the spec mandates that PIO0-2 are supported and there's
no reason not to support PIO3 IMO.
Signed-off-by: Brett Russ <russb@emc.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/scsi/ahci.c | 2 | ||||
| -rw-r--r-- | drivers/scsi/sata_uli.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c index 3106526..320df6c 100644 --- a/drivers/scsi/ahci.c +++ b/drivers/scsi/ahci.c @@ -250,7 +250,7 @@ static struct ata_port_info ahci_port_info[] = { .host_flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY | ATA_FLAG_SATA_RESET | ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA, - .pio_mask = 0x03, /* pio3-4 */ + .pio_mask = 0x1f, /* pio0-4 */ .udma_mask = 0x7f, /* udma0-6 ; FIXME */ .port_ops = &ahci_ops, }, diff --git a/drivers/scsi/sata_uli.c b/drivers/scsi/sata_uli.c index 1566886..42e13ed 100644 --- a/drivers/scsi/sata_uli.c +++ b/drivers/scsi/sata_uli.c @@ -125,8 +125,8 @@ static struct ata_port_info uli_port_info = { .sht = &uli_sht, .host_flags = ATA_FLAG_SATA | ATA_FLAG_SATA_RESET | ATA_FLAG_NO_LEGACY, - .pio_mask = 0x03, //support pio mode 4 (FIXME) - .udma_mask = 0x7f, //support udma mode 6 + .pio_mask = 0x1f, /* pio0-4 */ + .udma_mask = 0x7f, /* udma0-6 */ .port_ops = &uli_ops, }; |