diff options
| author | Steve French <sfrench@us.ibm.com> | 2009-02-25 14:19:56 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2009-03-12 01:36:21 +0000 |
| commit | 1adcb71092f6461c4002ccf29d316f6da3e1f39b (patch) | |
| tree | bc2238c4e473542f0b18bec7433f92d58d53b216 /fs/cifs/inode.c | |
| parent | 4717bed6806dab0270e5bfbc45e9f999e63ededd (diff) | |
| download | kernel_samsung_crespo-1adcb71092f6461c4002ccf29d316f6da3e1f39b.zip kernel_samsung_crespo-1adcb71092f6461c4002ccf29d316f6da3e1f39b.tar.gz kernel_samsung_crespo-1adcb71092f6461c4002ccf29d316f6da3e1f39b.tar.bz2 | |
[CIFS] add extra null attr check
Although attr == NULL can not happen, this makes cifs_set_file_info safer
in the future since it may not be obvious that the caller can not set
attr to NULL.
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/inode.c')
| -rw-r--r-- | fs/cifs/inode.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 4690a36..a8797cc 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -763,6 +763,9 @@ cifs_set_file_info(struct inode *inode, struct iattr *attrs, int xid, struct cifsTconInfo *pTcon = cifs_sb->tcon; FILE_BASIC_INFO info_buf; + if (attrs == NULL) + return -EINVAL; + if (attrs->ia_valid & ATTR_ATIME) { set_time = true; info_buf.LastAccessTime = |