diff options
| author | Jaegeuk Kim <jaegeuk.kim@samsung.com> | 2013-11-28 12:55:13 +0900 |
|---|---|---|
| committer | Andreas Blaesius <skate4life@gmx.de> | 2016-06-05 21:20:58 +0200 |
| commit | 75196ca757e202575ae10fd07d0cd38804397a69 (patch) | |
| tree | 2e3530d80d17853317d3ebe581dd1bc35274c830 | |
| parent | ef85bdf069edf515b0c13275e9c53dcbc1c4efc5 (diff) | |
| download | kernel_samsung_espresso10-75196ca757e202575ae10fd07d0cd38804397a69.zip kernel_samsung_espresso10-75196ca757e202575ae10fd07d0cd38804397a69.tar.gz kernel_samsung_espresso10-75196ca757e202575ae10fd07d0cd38804397a69.tar.bz2 | |
f2fs: remove unnecessary condition checks
This patch removes the unnecessary condition checks on:
fs/f2fs/gc.c:667 do_garbage_collect() warn: 'sum_page' isn't an ERR_PTR
fs/f2fs/f2fs.h:795 f2fs_put_page() warn: 'page' isn't an ERR_PTR
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
| -rw-r--r-- | fs/f2fs/f2fs.h | 2 | ||||
| -rw-r--r-- | fs/f2fs/gc.c | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index a149b22..7f8b808 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -792,7 +792,7 @@ static inline unsigned int valid_inode_count(struct f2fs_sb_info *sbi) static inline void f2fs_put_page(struct page *page, int unlock) { - if (!page || IS_ERR(page)) + if (!page) return; if (unlock) { diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 1d338d7..b8e8c2f 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -664,8 +664,6 @@ static void do_garbage_collect(struct f2fs_sb_info *sbi, unsigned int segno, /* read segment summary of victim */ sum_page = get_sum_page(sbi, segno); - if (IS_ERR(sum_page)) - return; blk_start_plug(&plug); |