aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2014-04-02 09:04:42 +0900
committerAndreas Blaesius <skate4life@gmx.de>2016-06-05 21:21:25 +0200
commitbb25711744c7c3086389c780a5ebfd147f9f6cce (patch)
treeabceddf66eeed99baed7ca64ba8a252f3c8a9257
parent67573b9442373dc9d0038e60e8236b2af0e3a39e (diff)
downloadkernel_samsung_espresso10-bb25711744c7c3086389c780a5ebfd147f9f6cce.zip
kernel_samsung_espresso10-bb25711744c7c3086389c780a5ebfd147f9f6cce.tar.gz
kernel_samsung_espresso10-bb25711744c7c3086389c780a5ebfd147f9f6cce.tar.bz2
f2fs: fix to cover io->bio with io_rwsem
In the f2fs_wait_on_page_writeback, io->bio should be covered by io_rwsem. Otherwise, the bio pointer can become a dangling pointer due to data races. Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
-rw-r--r--fs/f2fs/segment.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index cb49e63..f799c6a 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1049,15 +1049,14 @@ static inline bool is_merged_page(struct f2fs_sb_info *sbi,
{
enum page_type btype = PAGE_TYPE_OF_BIO(type);
struct f2fs_bio_info *io = &sbi->write_io[btype];
- struct bio *bio = io->bio;
struct bio_vec *bvec;
int i;
down_read(&io->io_rwsem);
- if (!bio)
+ if (!io->bio)
goto out;
- bio_for_each_segment_all(bvec, bio, i) {
+ bio_for_each_segment_all(bvec, io->bio, i) {
if (page == bvec->bv_page) {
up_read(&io->io_rwsem);
return true;